Issue 6622050: code review 6622050: go.crypto/blowfish: mention that only 16 bytes of salt ...

Issue 6622050: code review 6622050: go.crypto/blowfish: mention that only 16 bytes of salt ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by dchest

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

go.crypto/blowfish: document that only 16 bytes of salt are used. Also fix salt expansion code to fill the properly sized array, since the following code never uses more than 4 uints. Also remove unused expandedKey array.

Patch Set 1 #

Patch Set 2 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Total comments: 5

Patch Set 7 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r ad8a96e038bb https://code.google.com/p/go.crypto #

Patch Set 9 : diff -r 671a5c2bfac2 https://code.google.com/p/go.crypto #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	blowfish/block.go	View	1 2 3 4 5 6 7	2 chunks	+5 lines, -7 lines	0 comments	Download
	M	blowfish/cipher.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dchest

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

14 years ago (2012-10-05 17:28:37 UTC) #1

agl1

LGTM https://codereview.appspot.com/6622050/diff/3003/blowfish/block.go File blowfish/block.go (right): https://codereview.appspot.com/6622050/diff/3003/blowfish/block.go#newcode59 blowfish/block.go:59: d = d<<8 | uint32(key[j])&0x000000FF This & is ...

14 years ago (2012-10-05 18:12:44 UTC) #3

dchest

PTAL https://codereview.appspot.com/6622050/diff/3003/blowfish/block.go File blowfish/block.go (right): https://codereview.appspot.com/6622050/diff/3003/blowfish/block.go#newcode17 blowfish/block.go:17: d = d<<8 | uint32(key[j])&0x000000FF And here too, ...

14 years ago (2012-10-05 19:12:08 UTC) #4

agl1

14 years ago (2012-10-06 14:04:06 UTC) #5

*** Submitted as
http://code.google.com/p/go/source/detail?r=33051f713476&repo=crypto ***

go.crypto/blowfish: document that only 16 bytes of salt are used.

Also fix salt expansion code to fill the properly sized array,
since the following code never uses more than 4 uints.

Also remove unused expandedKey array.

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6622050

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages