Issue 6620055: Derive SkLightingImageFilter from SkSingleInputImageFilter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6620055: Derive SkLightingImageFilter from SkSingleInputImageFilter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Stephen White

Modified:
11 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Change SkLightingImageFilter to derive from SkSingleInputImageFilter, so that it can participate in filter DAGs. No tests yet. Committed: https://code.google.com/p/skia/source/browse/?r=5832

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -31 lines)			Patch
	M	include/effects/SkLightingImageFilter.h	View		2 chunks	+13 lines, -10 lines	0 comments	Download
	M	src/effects/SkLightingImageFilter.cpp	View		6 chunks	+29 lines, -21 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Stephen White

Broke this out from https://codereview.appspot.com/6443119/ to make it smaller. PTAL.

11 years, 11 months ago (2012-10-05 15:47:26 UTC) #1

reed1

11 years, 11 months ago (2012-10-05 16:29:37 UTC) #2

lgtm

perhaps with the future change to ImageFIlter to know more about inputs, we can
eliminate the need for SingleInput...

Expand All Messages | Collapse All Messages