Issue 6618065: Make GrDrawState::AutoRestoreViewMatrix handle sampler matrices.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6618065: Make GrDrawState::AutoRestoreViewMatrix handle sampler matrices. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrDrawState::AutoRestoreViewMatrix handle sampler matrices. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5853

Patch Set 3 : #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -76 lines)			Patch
M	src/gpu/GrContext.cpp	View	1	5 chunks	+6 lines, -15 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1	1 chunk	+36 lines, -40 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View	1	3 chunks	+47 lines, -14 lines	2 comments	Download
M	src/gpu/GrStencilAndCoverPathRenderer.cpp	View	1 2	3 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 1 possible (weakly suggested) enhancement https://codereview.appspot.com/6618065/diff/4001/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.appspot.com/6618065/diff/4001/src/gpu/GrDrawState.cpp#newcode54 src/gpu/GrDrawState.cpp:54: uint32_t explicitCoordStageMask) ...

12 years, 1 month ago (2012-10-08 15:45:24 UTC) #2

bsalomon

12 years, 1 month ago (2012-10-08 17:15:46 UTC) #3

https://codereview.appspot.com/6618065/diff/4001/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.appspot.com/6618065/diff/4001/src/gpu/GrDrawState.cpp#newc...
src/gpu/GrDrawState.cpp:54: uint32_t explicitCoordStageMask) {
On 2012/10/08 15:45:24, robertphillips wrote:
> Split this following block out into a "restore" or reset method?

Done.

Expand All Messages | Collapse All Messages