code review 6618062: test: convert tests to run.go whenever possible.

test: convert tests to run.go whenever possible.

The other tests either need a complex procedure
or are architecture- or OS-dependent.

Update issue 4139.

[remyoudompheng, 2012-10-07 21:48:32]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-10-10 18:34:25]

ping

[DMorsing, 2012-10-10 19:39:44]

Some weirdness going on here that makes me think you forgot to add some new
files.

https://codereview.appspot.com/6618062/diff/4016/test/fixedbugs/bug437.go
File test/fixedbugs/bug437.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/fixedbugs/bug437.go#new...
test/fixedbugs/bug437.go:11: package ignored
Where did this body go?

https://codereview.appspot.com/6618062/diff/4016/test/interface/embed1.go
File test/interface/embed1.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/embed1.go#new...
test/interface/embed1.go:9: package ignored
Ditto.

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.go
File test/interface/private.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.go#ne...
test/interface/private.go:1: // errorcheckdir
errchk is being run on this file in the original test. You'll need to introduce
it's contents into a new file in private.dir

[remyoudompheng, 2012-10-10 19:49:11]

sorry for the hg copy'ies

https://codereview.appspot.com/6618062/diff/4016/test/fixedbugs/bug437.go
File test/fixedbugs/bug437.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/fixedbugs/bug437.go#new...
test/fixedbugs/bug437.go:11: package ignored
On 2012/10/10 19:39:44, DMorsing wrote:
> Where did this body go?

to bug437.dir/x.go

https://codereview.appspot.com/6618062/diff/4016/test/interface/embed1.go
File test/interface/embed1.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/embed1.go#new...
test/interface/embed1.go:9: package ignored
went to embed1.dir/embed1.go

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.go
File test/interface/private.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.go#ne...
test/interface/private.go:1: // errorcheckdir
On 2012/10/10 19:39:44, DMorsing wrote:
> errchk is being run on this file in the original test. You'll need to
introduce
> it's contents into a new file in private.dir

Went to private.dir/prog.go

[iant, 2012-10-10 20:08:00]

LGTM

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/p...
File test/interface/private.dir/private1.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/p...
test/interface/private.dir/private1.go:1: // skip # used by private.go
You can remove the // skip comment.

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/p...
File test/interface/private.dir/prog.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/p...
test/interface/private.dir/prog.go:1: // $G $D/${F}1.go && errchk $G $D/$F.go
You can remove this leading comment.

https://codereview.appspot.com/6618062/diff/4016/test/interface/recursive1.di...
File test/interface/recursive1.dir/recursive1.go (right):

https://codereview.appspot.com/6618062/diff/4016/test/interface/recursive1.di...
test/interface/recursive1.dir/recursive1.go:1: // skip # used by recursive2
You can remove this leading comment.

[remyoudompheng, 2012-10-10 20:35:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=cd34abb3699f ***

test: convert tests to run.go whenever possible.

The other tests either need a complex procedure
or are architecture- or OS-dependent.

Update issue 4139.

R=golang-dev, daniel.morsing, iant
CC=golang-dev
http://codereview.appspot.com/6618062

http://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/pr...
File test/interface/private.dir/private1.go (right):

http://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/pr...
test/interface/private.dir/private1.go:1: // skip # used by private.go
On 2012/10/10 20:08:00, iant wrote:
> You can remove the // skip comment.

Done.

http://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/pr...
File test/interface/private.dir/prog.go (right):

http://codereview.appspot.com/6618062/diff/4016/test/interface/private.dir/pr...
test/interface/private.dir/prog.go:1: // $G $D/${F}1.go && errchk $G $D/$F.go
On 2012/10/10 20:08:00, iant wrote:
> You can remove this leading comment.

Done.

http://codereview.appspot.com/6618062/diff/4016/test/interface/recursive1.dir...
File test/interface/recursive1.dir/recursive1.go (right):

http://codereview.appspot.com/6618062/diff/4016/test/interface/recursive1.dir...
test/interface/recursive1.dir/recursive1.go:1: // skip # used by recursive2
On 2012/10/10 20:08:00, iant wrote:
> You can remove this leading comment.

Done.