Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 6615078: code review 6615078: os/signal: add Notify example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
9 years, 8 months ago
Reviewers:
CC:
golang-dev, dsymonds, r
Visibility:
Public.

Description

os/signal: add Notify example

Patch Set 1 #

Patch Set 2 : diff -r 8f3e3876b690 https://code.google.com/p/go #

Total comments: 4

Patch Set 3 : diff -r aa2adb62e2ce https://code.google.com/p/go #

Patch Set 4 : diff -r 57e13fc87f43 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A src/pkg/os/signal/example_test.go View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2012-10-11 06:01:03 UTC) #1
adg
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-10-11 06:02:12 UTC) #2
dsymonds
LGTM http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_test.go File src/pkg/os/signal/example_test.go (right): http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_test.go#newcode11 src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal) you almost always want ...
9 years, 8 months ago (2012-10-11 06:33:42 UTC) #3
r
http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_test.go File src/pkg/os/signal/example_test.go (right): http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_test.go#newcode11 src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal) ... and explain why
9 years, 8 months ago (2012-10-11 06:36:45 UTC) #4
adg
PTAL https://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_test.go File src/pkg/os/signal/example_test.go (right): https://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_test.go#newcode11 src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal) On 2012/10/11 06:33:42, dsymonds ...
9 years, 8 months ago (2012-10-11 06:56:16 UTC) #5
dsymonds
LGTM but wait for r for his word-fu.
9 years, 8 months ago (2012-10-11 07:12:18 UTC) #6
r
LGTM is 'drop' the operative word here? what really happens?
9 years, 8 months ago (2012-10-11 07:41:36 UTC) #7
adg
On 11 October 2012 18:41, <r@golang.org> wrote: > LGTM > > is 'drop' the operative ...
9 years, 8 months ago (2012-10-11 22:31:49 UTC) #8
r
On Fri, Oct 12, 2012 at 9:31 AM, Andrew Gerrand <adg@golang.org> wrote: > On 11 ...
9 years, 8 months ago (2012-10-11 23:18:26 UTC) #9
adg
9 years, 8 months ago (2012-10-11 23:22:19 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=447b5d4b9ad7 ***

os/signal: add Notify example

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/6615078
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b