code review 6615078: os/signal: add Notify example

os/signal: add Notify example

[adg, 2012-10-11 06:01:03]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2012-10-11 06:02:12]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-10-11 06:33:42]

LGTM

http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_tes...
File src/pkg/os/signal/example_test.go (right):

http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_tes...
src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal)
you almost always want a buffered channel when using this in practice, so
demonstrate that here: add ", 1".

[r, 2012-10-11 06:36:45]

http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_tes...
File src/pkg/os/signal/example_test.go (right):

http://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_tes...
src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal)
... and explain why

[adg, 2012-10-11 06:56:16]

PTAL

https://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_te...
File src/pkg/os/signal/example_test.go (right):

https://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_te...
src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal)
On 2012/10/11 06:33:42, dsymonds wrote:
> you almost always want a buffered channel when using this in practice, so
> demonstrate that here: add ", 1".

Done.

https://codereview.appspot.com/6615078/diff/2001/src/pkg/os/signal/example_te...
src/pkg/os/signal/example_test.go:11: c := make(chan os.Signal)
On 2012/10/11 06:36:45, r wrote:
> ... and explain why

Done.

[dsymonds, 2012-10-11 07:12:18]

LGTM

but wait for r for his word-fu.

[r, 2012-10-11 07:41:36]

LGTM

is 'drop' the operative word here? what really happens?

[adg, 2012-10-11 22:31:49]

On 11 October 2012 18:41,  <r@golang.org> wrote:
> LGTM
>
> is 'drop' the operative word here? what really happens?

The signal handler in os/signal just does a non-blocking send to the
channel. s/dropping/missing/ ?

[r, 2012-10-11 23:18:26]

On Fri, Oct 12, 2012 at 9:31 AM, Andrew Gerrand <adg@golang.org> wrote:
> On 11 October 2012 18:41,  <r@golang.org> wrote:
>> LGTM
>>
>> is 'drop' the operative word here? what really happens?
>
> The signal handler in os/signal just does a non-blocking send to the
> channel. s/dropping/missing/ ?

OK

[adg, 2012-10-11 23:22:19]

*** Submitted as http://code.google.com/p/go/source/detail?r=447b5d4b9ad7 ***

os/signal: add Notify example

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/6615078