Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5009)

Issue 6615064: Make additional code paths go through GrDrawState helper classes for their matrix manipulations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bsalomon
Modified:
12 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make additional code paths go through GrDrawState helper classes for their matrix manipulations. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5856

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -22 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 4 chunks +10 lines, -9 lines 1 comment Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 2 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 2
bsalomon
https://codereview.appspot.com/6615064/diff/3004/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp (right): https://codereview.appspot.com/6615064/diff/3004/src/gpu/GrAAConvexPathRenderer.cpp#newcode500 src/gpu/GrAAConvexPathRenderer.cpp:500: GrDrawState::VertexEdgeType oldEdgeType = drawState->getVertexEdgeType(); I thought about making an ...
12 years, 1 month ago (2012-10-08 18:40:02 UTC) #1
robertphillips
12 years, 1 month ago (2012-10-08 18:50:45 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b