Issue 6615064: Make additional code paths go through GrDrawState helper classes for their matrix manipulations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6615064: Make additional code paths go through GrDrawState helper classes for their matrix manipulations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make additional code paths go through GrDrawState helper classes for their matrix manipulations. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5856

Patch Set 3 : #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -22 lines)			Patch
M	src/gpu/GrAAConvexPathRenderer.cpp	View		4 chunks	+10 lines, -9 lines	1 comment	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	1 2	3 chunks	+11 lines, -11 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1	2 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6615064/diff/3004/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp (right): https://codereview.appspot.com/6615064/diff/3004/src/gpu/GrAAConvexPathRenderer.cpp#newcode500 src/gpu/GrAAConvexPathRenderer.cpp:500: GrDrawState::VertexEdgeType oldEdgeType = drawState->getVertexEdgeType(); I thought about making an ...

11 years, 8 months ago (2012-10-08 18:40:02 UTC) #1

LGTM

Expand All Messages | Collapse All Messages