Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(354)

Issue 6615062: Remove translate param from GrContext::drawPath (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bsalomon
Modified:
12 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove translate param from GrContext::drawPath (and subsequent calls). Committed: https://code.google.com/p/skia/source/detail?r=5852

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -85 lines) Patch
M include/gpu/GrContext.h View 1 3 chunks +7 lines, -4 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 8 chunks +1 line, -12 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 5 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 6 chunks +1 line, -16 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 3 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +9 lines, -3 lines 2 comments Download

Messages

Total messages: 3
bsalomon
The translate param on GrContext::drawPath was giving me grief while working on how we handle ...
12 years, 2 months ago (2012-10-08 14:24:22 UTC) #1
robertphillips
LGTM + 1 question https://codereview.appspot.com/6615062/diff/5/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.appspot.com/6615062/diff/5/src/gpu/SkGpuDevice.cpp#newcode880 src/gpu/SkGpuDevice.cpp:880: Is this really supposed to ...
12 years, 2 months ago (2012-10-08 14:33:18 UTC) #2
bsalomon
12 years, 2 months ago (2012-10-08 14:44:37 UTC) #3
https://codereview.appspot.com/6615062/diff/5/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.appspot.com/6615062/diff/5/src/gpu/SkGpuDevice.cpp#newcode880
src/gpu/SkGpuDevice.cpp:880: 
On 2012/10/08 14:33:18, robertphillips wrote:
> Is this really supposed to be preserve?

Yeah, The code below now first replaces the current matrix with a translation
matrix and then with an identity matrix.  It seemed better to me to do nothing
to the matrix here then to move the translation setup here, away from the draw.

I'll add a comment to make it more clear.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b