Issue 6615046: Rename GrPaint fields/enums/members texture->color mask->coverage.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6615046: Rename GrPaint fields/enums/members texture->color mask->coverage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bsalomon

Modified:
11 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Rename GrPaint fields/enums/members texture->color mask->coverage. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5827

Patch Set 3 : #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -119 lines)			Patch
M	gm/texdata.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/gpu/GrPaint.h	View	1 2	6 chunks	+49 lines, -50 lines	2 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		23 chunks	+35 lines, -35 lines	0 comments	Download
M	src/gpu/effects/GrConfigConversionEffect.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Simple rename change that fixes some long-outdated names on GrPaint.

11 years, 8 months ago (2012-10-05 14:36:01 UTC) #1

robertphillips

LGTM + 1 question https://codereview.appspot.com/6615046/diff/2001/include/gpu/GrPaint.h File include/gpu/GrPaint.h (right): https://codereview.appspot.com/6615046/diff/2001/include/gpu/GrPaint.h#newcode94 include/gpu/GrPaint.h:94: Is there a better name ...

11 years, 8 months ago (2012-10-05 14:44:38 UTC) #2

bsalomon

11 years, 8 months ago (2012-10-05 14:49:54 UTC) #3

https://codereview.appspot.com/6615046/diff/2001/include/gpu/GrPaint.h
File include/gpu/GrPaint.h (right):

https://codereview.appspot.com/6615046/diff/2001/include/gpu/GrPaint.h#newcode94
include/gpu/GrPaint.h:94: 
On 2012/10/05 14:44:39, robertphillips wrote:
> Is there a better name (not that I can think of one)?

hmm... hasEnabledStage()?

Expand All Messages | Collapse All Messages