Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(119)

Issue 6613064: code review 6613064: container/heap: optimization in case heap has many dupl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by taj
Modified:
9 years, 11 months ago
Reviewers:
CC:
gri, golang-dev
Visibility:
Public.

Description

container/heap: optimization in case heap has many duplicates benchmark old ns/op new ns/op delta BenchmarkDup 3075682 609448 -80.18%

Patch Set 1 #

Patch Set 2 : diff -r 30663f5bdd69 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 30663f5bdd69 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r c3570e8ed478 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/pkg/container/heap/heap.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/container/heap/heap_test.go View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6
taj
Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 11 months ago (2012-10-06 20:57:33 UTC) #1
gri
Looks good. Some suggestions below. https://codereview.appspot.com/6613064/diff/3001/src/pkg/container/heap/heap_test.go File src/pkg/container/heap/heap_test.go (right): https://codereview.appspot.com/6613064/diff/3001/src/pkg/container/heap/heap_test.go#newcode176 src/pkg/container/heap/heap_test.go:176: h := new(myHeap) You ...
9 years, 11 months ago (2012-10-10 01:29:09 UTC) #2
taj
Hello gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 11 months ago (2012-10-10 06:52:23 UTC) #3
taj
On 2012/10/10 06:52:23, taj wrote: > Hello mailto:gri@golang.org (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...
9 years, 11 months ago (2012-10-10 06:54:38 UTC) #4
gri
LGTM Thanks! - gri
9 years, 11 months ago (2012-10-10 18:35:07 UTC) #5
gri
9 years, 11 months ago (2012-10-10 18:36:01 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=7677524b8a24 ***

container/heap: optimization in case heap has many duplicates

benchmark       old ns/op    new ns/op    delta
BenchmarkDup      3075682       609448  -80.18%

R=gri
CC=golang-dev
http://codereview.appspot.com/6613064

Committer: Robert Griesemer <gri@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b