Issue 6609048: Reduce Android Log Spam.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6609048: Reduce Android Log Spam. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by DerekS

Modified:
11 years, 11 months ago

Reviewers:
TomH, EricB, newt

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Reduce Android Log Spam. The logging of system fonts is now hidden behind a #define Committed: https://code.google.com/p/skia/source/detail?r=5825

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
	M	src/ports/SkFontHost_android.cpp	View		5 chunks	+26 lines, -11 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

newt

LGTM! with 2 nits https://codereview.appspot.com/6609048/diff/1/src/ports/SkFontHost_android.cpp File src/ports/SkFontHost_android.cpp (right): https://codereview.appspot.com/6609048/diff/1/src/ports/SkFontHost_android.cpp#newcode37 src/ports/SkFontHost_android.cpp:37: #define SK_DEBUG_FONTS 0 is this ...

11 years, 11 months ago (2012-10-05 15:01:25 UTC) #3

DerekS

On 2012/10/05 15:01:25, newt wrote: > LGTM! with 2 nits > > https://codereview.appspot.com/6609048/diff/1/src/ports/SkFontHost_android.cpp > File ...

11 years, 11 months ago (2012-10-05 15:16:13 UTC) #4

clean-up is in https://codereview.appspot.com/6621054/

Expand All Messages | Collapse All Messages