Add caja compatible flash support to shindig

Mike Stay's patch which:
* adds support for flash in cajoled gadgets
* uses the ref_send library to communicate between flash and js on the container page

[Jasvir, 2009-06-02 04:56:47]

This patch includes a bridge swf which needs to be hosted somewhere where it
will get served by shindig but it was not obvious where that should sit.

[Jasvir, 2009-07-29 22:32:57]

On 2009/06/02 04:56:47, jasvir wrote:
> This patch includes a bridge swf which needs to be hosted somewhere where it
> will get served by shindig but it was not obvious where that should sit.

After chatting with lryan, moved flash Bridge code in javascript/container/.

[Paul Lindner, 2009-07-30 20:42:58]

stylistically looks good.  Can't comment on the technical aspects of caja since
I don't know it that well.

[louiscryan, 2009-08-18 17:49:52]

http://codereview.appspot.com/66045/diff/4001/4005
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/66045/diff/4001/4005#newcode289
Line 289: width: 1,
can these be 0. as is this will occupy some of the layout

http://codereview.appspot.com/66045/diff/4001/4004
File features/src/main/javascript/features/flash/flash.js (right):

http://codereview.appspot.com/66045/diff/4001/4004#newcode123
Line 123: a.href = swfUrl;
why create the href? to have the swf url be resolved?
the swf will invariably be absolute because it is either proxied or it will be
on a different domain than the gadget.

http://codereview.appspot.com/66045/diff/4001/4003
File javascript/container/Bridge.as (right):

http://codereview.appspot.com/66045/diff/4001/4003#newcode1
Line 1: import flash.external.ExternalInterface;
Needs an Apache license

http://codereview.appspot.com/66045/diff/4001/4003#newcode11
Line 11: _root.message.text += "callSWF\n";
condition check to enable logging based on swf params.

can this call out to gadgets.log instead? logging the method would also be
useful.

[metaweta, 2009-08-21 19:58:19]

On 2009/08/18 17:49:52, louiscryan wrote:
> http://codereview.appspot.com/66045/diff/4001/4005
> File features/src/main/javascript/features/caja/taming.js (right):
> 
> http://codereview.appspot.com/66045/diff/4001/4005#newcode289
> Line 289: width: 1,
> can these be 0. as is this will occupy some of the layout

OK, will change.

> http://codereview.appspot.com/66045/diff/4001/4004
> File features/src/main/javascript/features/flash/flash.js (right):
> 
> http://codereview.appspot.com/66045/diff/4001/4004#newcode123
> Line 123: a.href = swfUrl;
> why create the href? to have the swf url be resolved?
> the swf will invariably be absolute because it is either proxied or it will be
> on a different domain than the gadget.

No, because I use the same code for embedding the bridge, which is a relative
URL.

> http://codereview.appspot.com/66045/diff/4001/4003
> File javascript/container/Bridge.as (right):
> 
> http://codereview.appspot.com/66045/diff/4001/4003#newcode1
> Line 1: import flash.external.ExternalInterface;
> Needs an Apache license

Bridge.as needs the licence, or ExternalInterface does?

> http://codereview.appspot.com/66045/diff/4001/4003#newcode11
> Line 11: _root.message.text += "callSWF\n";
> condition check to enable logging based on swf params.

OK, will do.

> can this call out to gadgets.log instead? logging the method would also be
> useful.

Yes, I can invoke gadgets.log via externalinterface.

[metaweta, 2009-09-05 20:22:04]

Please review the new ticket
http://codereview.appspot.com/116048

[metaweta, 2009-09-26 17:26:28]

On 2009/09/05 20:22:04, metaweta wrote:
> Please review the new ticket
> http://codereview.appspot.com/116048

@jasvir: This ticket can be closed.