Export effects classes with SK_API.

Export effects classes with SK_API.

So this works in shared_library build in chromium.

This issue was raised up in the following chromium-dev thread:
https://groups.google.com/a/chromium.org/forum/?hl=en&fromgroups=#!topic/chromium-dev/Z6qzEw8MwVY

R=epoger@google.com,tomhudson@google.com

Committed: https://code.google.com/p/skia/source/detail?r=5914

[tfarina1, 2012-10-11 22:44:40]

Please, could you review this to me?

[TomH, 2012-10-12 03:24:09]

I can try to look at it, but somebody else might have a better sense
of the history of SK_API - Mike? Ben?

Tom

On Thu, Oct 11, 2012 at 11:44 PM,  <tfarina@chromium.org> wrote:
> Reviewers: epoger, TomH,
>
> Message:
> Please, could you review this to me?
>
> Description:
> Export effects classes with SK_API.
>
> So this works in shared_library build in chromium.
>
> This issue was raised up in the following chromium-dev thread:
>
https://groups.google.com/a/chromium.org/forum/?hl=en&fromgroups=#!topic/chro...
>
> R=epoger@google.com,tomhudson@google.com
>
>
> Please review this at https://codereview.appspot.com/6601065/
>
> Affected files:
>   M include/effects/Sk1DPathEffect.h
>   M include/effects/Sk2DPathEffect.h
>   M include/effects/SkArithmeticMode.h
>   M include/effects/SkAvoidXfermode.h
>   M include/effects/SkBitmapSource.h
>   M include/effects/SkBlendImageFilter.h
>   M include/effects/SkBlurDrawLooper.h
>   M include/effects/SkBlurImageFilter.h
>   M include/effects/SkBlurMaskFilter.h
>   M include/effects/SkColorFilterImageFilter.h
>   M include/effects/SkColorMatrix.h
>   M include/effects/SkColorMatrixFilter.h
>   M include/effects/SkCornerPathEffect.h
>   M include/effects/SkDashPathEffect.h
>   M include/effects/SkDiscretePathEffect.h
>   M include/effects/SkDrawExtraPathEffect.h
>   M include/effects/SkEmbossMaskFilter.h
>   M include/effects/SkKernel33MaskFilter.h
>   M include/effects/SkLayerDrawLooper.h
>   M include/effects/SkLayerRasterizer.h
>   M include/effects/SkMatrixConvolutionImageFilter.h
>   M include/effects/SkPaintFlagsDrawFilter.h
>   M include/effects/SkPixelXorXfermode.h
>   M include/effects/SkPorterDuff.h
>   M include/effects/SkStippleMaskFilter.h
>   M include/effects/SkTableMaskFilter.h
>   M include/effects/SkTestImageFilters.h
>   M include/effects/SkTransparentShader.h
>
>

[TomH, 2012-10-12 13:33:23]

I won't sign off without reed@ or somebody else who knows the SK_API philosophy.
Mike, feel free to delegate to somebody on the team who knows what's what.

As I mention inline, Skia philosophy is to separate whitespace / intendation /
formating / standards-compliance commits from functional commits. A good third
of the files you touched in this CL are just tweaking whitespace.

https://codereview.appspot.com/6601065/diff/1/include/effects/Sk1DPathEffect.h
File include/effects/Sk1DPathEffect.h (right):

https://codereview.appspot.com/6601065/diff/1/include/effects/Sk1DPathEffect....
include/effects/Sk1DPathEffect.h:17: class SK_API Sk1DPathEffect : public
SkPathEffect {
This is an abstract virtual base class - does it need to be SK_API?

https://codereview.appspot.com/6601065/diff/1/include/effects/SkBlendImageFil...
File include/effects/SkBlendImageFilter.h (left):

https://codereview.appspot.com/6601065/diff/1/include/effects/SkBlendImageFil...
include/effects/SkBlendImageFilter.h:52: 
Verify that the housekeeping bots aren't adding trailing <CR> back in these
days?

In general, we don't want to combine whitespace-fixes or other cleanup with
anything semantically significant.

[reed1, 2012-10-12 13:41:54]

There are a lot of white-space only changes here too. Lets commit this as is,
but in the future please separate that kind of change out.

lgtm

[tfarina1, 2012-10-12 14:48:35]

On 2012/10/12 13:33:23, TomH wrote:
> As I mention inline, Skia philosophy is to separate whitespace / intendation /
> formating / standards-compliance commits from functional commits. A good third
> of the files you touched in this CL are just tweaking whitespace.
> 
My bad. I did because I have had to open all the header files in order to add
the SK_API, so went away doing this with the thought: hey lets fix these
whitespace mistakes while I'm here, because otherwise they won't let me do this
in a separate clean up CL that adds nothing (as Mike has pointed out to me
sometimes before, that is not to spend time with clean up patches, just with
bugs and performance issues) ;). So I thought it would be fine as it wouldn't
being distracting too much from the main issue that we were fixing with this CL.