Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(384)

Issue 660042: Compatible numeric hashes

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by dickinsm
Modified:
8 years, 12 months ago
Reviewers:
GvR, Christophe Simonis
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Cleaned up version of original patch; add documentation. #

Patch Set 3 : Updated patch, with less repetition and more tests. #

Total comments: 10

Patch Set 4 : Address comments on previous patch. #

Patch Set 5 : Implement exact comparisons between numeric types. #

Patch Set 6 : Add docs and tests for sys.hash_info, docs for hashing strategy. #

Total comments: 2

Patch Set 7 : Add details about complex hash computation; reorganize sys.hash_info #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -155 lines) Patch
M Doc/library/decimal.rst View 6 1 chunk +9 lines, -15 lines 0 comments Download
M Doc/library/stdtypes.rst View 6 1 chunk +104 lines, -0 lines 2 comments Download
M Doc/library/sys.rst View 6 1 chunk +24 lines, -0 lines 0 comments Download
M Include/pyport.h View 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
M Lib/decimal.py View 1 2 3 4 5 6 9 chunks +57 lines, -47 lines 0 comments Download
M Lib/fractions.py View 1 2 3 4 5 6 3 chunks +16 lines, -9 lines 0 comments Download
M Lib/test/test_float.py View 1 chunk +0 lines, -9 lines 0 comments Download
M Lib/test/test_fractions.py View 5 6 1 chunk +1 line, -2 lines 0 comments Download
A Lib/test/test_numeric_tower.py View 1 2 3 4 5 6 1 chunk +207 lines, -0 lines 0 comments Download
M Lib/test/test_sys.py View 6 1 chunk +17 lines, -0 lines 0 comments Download
M Objects/complexobject.c View 2 chunks +9 lines, -9 lines 0 comments Download
M Objects/longobject.c View 1 2 3 4 5 6 1 chunk +29 lines, -10 lines 0 comments Download
M Objects/object.c View 1 2 3 4 5 6 1 chunk +86 lines, -48 lines 0 comments Download
M Objects/typeobject.c View 1 2 3 4 5 6 2 chunks +20 lines, -6 lines 0 comments Download
M Python/sysmodule.c View 3 4 5 6 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 6
GvR
(This is not a complete review, just some things that popped into my mind. Hopefully ...
9 years, 2 months ago (2010-03-21 17:04:48 UTC) #1
dickinsm
http://codereview.appspot.com/660042/diff/19001/11011 File Objects/longobject.c (right): http://codereview.appspot.com/660042/diff/19001/11011#newcode2577 Objects/longobject.c:2577: this multiplies by 2**PyLong_SHIFT modulo 2**31 - 1. */ ...
9 years, 1 month ago (2010-03-23 11:56:56 UTC) #2
dickinsm
http://codereview.appspot.com/660042/diff/19001/11010 File Objects/typeobject.c (right): http://codereview.appspot.com/660042/diff/19001/11010#newcode4938 Objects/typeobject.c:4938: if (PyLong_Check(res)) On 2010/03/23 11:56:56, dickinsm wrote: > Need ...
9 years, 1 month ago (2010-03-23 12:12:09 UTC) #3
Christophe Simonis
http://codereview.appspot.com/660042/diff/42010/51008 File Doc/library/stdtypes.rst (right): http://codereview.appspot.com/660042/diff/42010/51008#newcode674 Doc/library/stdtypes.rst:674: hash = -2 Error: must be hash_ = -2
9 years, 1 month ago (2010-04-04 17:15:20 UTC) #4
dickinsm
http://codereview.appspot.com/660042/diff/42010/51008 File Doc/library/stdtypes.rst (right): http://codereview.appspot.com/660042/diff/42010/51008#newcode674 Doc/library/stdtypes.rst:674: hash = -2 On 2010/04/04 17:15:20, Christophe Simonis wrote: ...
8 years, 12 months ago (2010-05-22 10:05:57 UTC) #5
dickinsm
8 years, 12 months ago (2010-05-23 10:46:32 UTC) #6
http://codereview.appspot.com/660042/diff/63001/64009
File Doc/library/stdtypes.rst (right):

http://codereview.appspot.com/660042/diff/63001/64009#newcode631
Doc/library/stdtypes.rst:631: - If ``x = m / n`` is a negative rational number
and ``n`` is not divisible by
Remove the "and ``n`` is not divisible by ``P``" here.

http://codereview.appspot.com/660042/diff/63001/64009#newcode637
Doc/library/stdtypes.rst:637: - The particular values ``sys.hash_info.inf``,
``sys.hash_info.ninf`` and
"sys.hash_info.ninf" should be "-sys.hash_info.inf".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b