Issue 66000043: utils/voyeur: zero Value is ok to use

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66000043: utils/voyeur: zero Value is ok to use

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rog

Modified:
10 years, 3 months ago

Reviewers:
mp+207184, natefinch

Visibility:
Public.

Description

utils/voyeur: zero Value is ok to use This can make it more convenient to use in some cases. https://code.launchpad.net/~rogpeppe/juju-core/506-voyeur-allow-zero-value/+merge/207184 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : utils/voyeur: zero Value is ok to use #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -10 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/voyeur/value.go	View	6 chunks	+33 lines, -10 lines	0 comments	Download
M	utils/voyeur/value_test.go	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.  Love having useful zero values.

Expand All Messages | Collapse All Messages