Issue 6599043: Explicitly set skia_osx_sdkroot on 10.6 buildbot machines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6599043: Explicitly set skia_osx_sdkroot on 10.6 buildbot machines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by epoger

Modified:
12 years, 8 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com, senorblanco

Base URL:
http://skia.googlecode.com/svn/buildbot/

Visibility:
Public.

More Reviews

Description

Explicitly set skia_osx_sdkroot on 10.6 buildbot machines This change will keep our bots working after https://codereview.appspot.com/6598055/ ('Change default skia_osx_sdkroot to "macosx" (suitable for Xcode 3.2.6+)') Committed: https://code.google.com/p/skia/source/detail?r=5788

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	master/master_builders_cfg.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

We would need to commit this CL *and restart the master* before committing https://codereview.appspot.com/6598055/

12 years, 8 months ago (2012-10-02 17:29:21 UTC) #1

EricB

12 years, 8 months ago (2012-10-02 18:37:47 UTC) #2

On 2012/10/02 17:29:21, epoger wrote:
> We would need to commit this CL *and restart the master* before committing
> https://codereview.appspot.com/6598055/

I seem to remember seeing multiple solutions to this problem.  I don't really
like having to set extra GYP defines if we can help it - are we sure there isn't
a better way?

Expand All Messages | Collapse All Messages