Change default skia_osx_sdkroot to "macosx" (suitable for Xcode 3.2.6+)

Change default skia_osx_sdkroot to "macosx" (suitable for Xcode 3.2.6+)
See https://codereview.appspot.com/6553044
BUG=https://code.google.com/p/skia/issues/detail?id=796
Committed: https://code.google.com/p/skia/source/detail?r=5806

[Stephen White, 2012-10-02 17:24:19]

Didn't this break some bots last time we tried it?

[epoger, 2012-10-02 17:25:46]

On 2012/10/02 17:24:19, Stephen White wrote:
> Didn't this break some bots last time we tried it?

It would have.  I have a separate change to the buildbot setup (not out for
review yet, but it would have to be committed FIRST) that should make it work.

[epoger, 2012-10-02 17:30:14]

On 2012/10/02 17:25:46, epoger wrote:
> On 2012/10/02 17:24:19, Stephen White wrote:
> > Didn't this break some bots last time we tried it?
> 
> It would have.  I have a separate change to the buildbot setup (not out for
> review yet, but it would have to be committed FIRST) that should make it work.

Here's the buildbot CL that would need to go in first:
https://codereview.appspot.com/6599043/ ('Explicitly set skia_osx_sdkroot on
buildbot machines')

[Stephen White, 2012-10-02 17:33:56]

On 2012/10/02 17:30:14, epoger wrote:
> On 2012/10/02 17:25:46, epoger wrote:
> > On 2012/10/02 17:24:19, Stephen White wrote:
> > > Didn't this break some bots last time we tried it?
> > 
> > It would have.  I have a separate change to the buildbot setup (not out for
> > review yet, but it would have to be committed FIRST) that should make it
work.
> 
> Here's the buildbot CL that would need to go in first:
> https://codereview.appspot.com/6599043/ ('Explicitly set skia_osx_sdkroot on
> buildbot machines')

That's fine for the bots, but what about some poor sod trying to build on his
local machine?

I think we'd be better off copying thakis@'s find-sdk script from Chrome: 
https://chromiumcodereview.appspot.com/10824055

Then we don't need to set anything on the bots, or locally.

[epoger, 2012-10-02 17:44:52]

> That's fine for the bots, but what about some poor sod trying to build on his
> local machine?
> 
> I think we'd be better off copying thakis@'s find-sdk script from Chrome: 
> https://chromiumcodereview.appspot.com/10824055

That find-sdk script is nifty, no doubt, but I think it's overly complicated
given that setting skia_osx_sdkroot=macosx should "just work" on all
installations with Xcode 3.2.6+

For developers with older setups, I have added the workaround to
https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/mac

How far back (in OS/Xcode versions) should we support?

[Stephen White, 2012-10-02 17:51:45]

On 2012/10/02 17:44:52, epoger wrote:
> > That's fine for the bots, but what about some poor sod trying to build on
his
> > local machine?
> > 
> > I think we'd be better off copying thakis@'s find-sdk script from Chrome: 
> > https://chromiumcodereview.appspot.com/10824055
> 
> That find-sdk script is nifty, no doubt, but I think it's overly complicated
> given that setting skia_osx_sdkroot=macosx should "just work" on all
> installations with Xcode 3.2.6+
> 
> For developers with older setups, I have added the workaround to
>
https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/mac
> 
> How far back (in OS/Xcode versions) should we support?

*shrug*.  Not really my call.  I just think it'd be nice to do it automatically
(the script isn't long, and is well-tested in Chrome).

But if you're not interested in doing that, I don't want to hold you up, so
LGTM.

[Stephen White, 2012-10-02 17:55:44]

On 2012/10/02 17:51:45, Stephen White wrote:
> On 2012/10/02 17:44:52, epoger wrote:
> > > That's fine for the bots, but what about some poor sod trying to build on
> his
> > > local machine?
> > > 
> > > I think we'd be better off copying thakis@'s find-sdk script from Chrome: 
> > > https://chromiumcodereview.appspot.com/10824055
> > 
> > That find-sdk script is nifty, no doubt, but I think it's overly complicated
> > given that setting skia_osx_sdkroot=macosx should "just work" on all
> > installations with Xcode 3.2.6+
> > 
> > For developers with older setups, I have added the workaround to
> >
>
https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/mac
> > 
> > How far back (in OS/Xcode versions) should we support?
> 
> *shrug*.  Not really my call.  I just think it'd be nice to do it
automatically
> (the script isn't long, and is well-tested in Chrome).
> 
> But if you're not interested in doing that, I don't want to hold you up, so
> LGTM.

One other nagging thought:  if the bots are setting the target SDK explicitly,
and local builds are not, is there a possibility that a developer will land
something that'll break on the bots but not in local builds?

[epoger, 2012-10-02 18:07:32]

On 2012/10/02 17:55:44, Stephen White wrote:
> On 2012/10/02 17:51:45, Stephen White wrote:
> > On 2012/10/02 17:44:52, epoger wrote:
> > > > That's fine for the bots, but what about some poor sod trying to build
on
> > his
> > > > local machine?
> > > > 
> > > > I think we'd be better off copying thakis@'s find-sdk script from
Chrome: 
> > > > https://chromiumcodereview.appspot.com/10824055
> > > 
> > > That find-sdk script is nifty, no doubt, but I think it's overly
complicated
> > > given that setting skia_osx_sdkroot=macosx should "just work" on all
> > > installations with Xcode 3.2.6+
> > > 
> > > For developers with older setups, I have added the workaround to
> > >
> >
>
https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides/mac
> > > 
> > > How far back (in OS/Xcode versions) should we support?
> > 
> > *shrug*.  Not really my call.  I just think it'd be nice to do it
> automatically
> > (the script isn't long, and is well-tested in Chrome).
> > 
> > But if you're not interested in doing that, I don't want to hold you up, so
> > LGTM.
> 
> One other nagging thought:  if the bots are setting the target SDK explicitly,
> and local builds are not, is there a possibility that a developer will land
> something that'll break on the bots but not in local builds?

That thought nags me too.  Explicit vs implicit target SDKs are one problem...
and beyond that, no matter what we do, different bots/developers will be
targeting different OS and compiler versions.

I'm just gonna leave this out here for a bit and see if anyone has an AHA
moment.

[epoger, 2012-10-03 17:30:18]

I've been talking about this with Eric and Edi today...

We've decided that changing the default skia_osx_sdkroot to "macosx" is the path
we'll take, at least for now.

Pro: should Just Work for all developers with Xcode 3.2.6+, doesn't add yet more
complexity to our gyp files

Con: developers (and 10.6 buildbots) that use an older Xcode will have to
override skia_osx_sdkroot

As such, I have committed https://codereview.appspot.com/6599043/ ('Explicitly
set skia_osx_sdkroot on 10.6 buildbot machines')... once we have restarted the
buildbot master to pick that up, I will commit this CL.

Eric, does all of that look right to you?

[EricB, 2012-10-03 17:31:10]

On 2012/10/03 17:30:18, epoger wrote:
> I've been talking about this with Eric and Edi today...
> 
> We've decided that changing the default skia_osx_sdkroot to "macosx" is the
path
> we'll take, at least for now.
> 
> Pro: should Just Work for all developers with Xcode 3.2.6+, doesn't add yet
more
> complexity to our gyp files
> 
> Con: developers (and 10.6 buildbots) that use an older Xcode will have to
> override skia_osx_sdkroot
> 
> As such, I have committed https://codereview.appspot.com/6599043/ ('Explicitly
> set skia_osx_sdkroot on 10.6 buildbot machines')... once we have restarted the
> buildbot master to pick that up, I will commit this CL.
> 
> Eric, does all of that look right to you?

SGTM

[edisonn, 2012-10-03 17:33:26]

lgtm

On Wed, Oct 3, 2012 at 1:31 PM, <borenet@google.com> wrote:

> On 2012/10/03 17:30:18, epoger wrote:
>
>> I've been talking about this with Eric and Edi today...
>>
>
>  We've decided that changing the default skia_osx_sdkroot to "macosx"
>>
> is the path
>
>> we'll take, at least for now.
>>
>
>  Pro: should Just Work for all developers with Xcode 3.2.6+, doesn't
>>
> add yet more
>
>> complexity to our gyp files
>>
>
>  Con: developers (and 10.6 buildbots) that use an older Xcode will have
>>
> to
>
>> override skia_osx_sdkroot
>>
>
>  As such, I have committed
https://codereview.appspot.**com/6599043/<https://codereview.appspot.com/6599...
>>
> ('Explicitly
>
>> set skia_osx_sdkroot on 10.6 buildbot machines')... once we have
>>
> restarted the
>
>> buildbot master to pick that up, I will commit this CL.
>>
>
>  Eric, does all of that look right to you?
>>
>
> SGTM
>
>
https://codereview.appspot.**com/6598055/<https://codereview.appspot.com/6598...
>