Issue 6597063: build iOS with 'make all'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6597063: build iOS with 'make all' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by caryclark1

Modified:
11 years, 8 months ago

Reviewers:
EricB, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

build iOS with 'make all' This builds all skia tests by treating iOS tools as executable applications. A few warnings were fixed as well. Removed old trace draw code and remnants. Committed: https://code.google.com/p/skia/source/detail?r=5776

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -41 lines)			Patch
M	bench/benchmain.cpp	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	experimental/SimpleiOSApp/SimpleApp.mm	View		4 chunks	+14 lines, -1 line	0 comments	Download
A	experimental/SimpleiOSApp/tool-Info.plist	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	experimental/iOSSampleApp/Shared/skia_ios.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	experimental/iOSSampleApp/SkSampleUIView.mm	View	1	6 chunks	+11 lines, -24 lines	0 comments	Download
M	gm/gmmain.cpp	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	gyp/apptype_console.gypi	View		1 chunk	+49 lines, -0 lines	0 comments	Download
M	gyp/common_variables.gypi	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/core/SkPaint.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/skia_test.cpp	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	tools/bench_pictures_main.cpp	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tools/pinspect.cpp	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tools/render_pictures_main.cpp	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tools/skdiff_main.cpp	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tools/skhello.cpp	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tools/skimage_main.cpp	View		2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

LGTM w/ one question. https://codereview.appspot.com/6597063/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.appspot.com/6597063/diff/1/samplecode/SampleApp.cpp#newcode2461 samplecode/SampleApp.cpp:2461: bool gDoTraceDraw; What's this?

11 years, 8 months ago (2012-10-02 17:37:28 UTC) #2

caryclark1

https://codereview.appspot.com/6597063/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.appspot.com/6597063/diff/1/samplecode/SampleApp.cpp#newcode2461 samplecode/SampleApp.cpp:2461: bool gDoTraceDraw; Obsolete code. Removed it and its prodgeny. ...

11 years, 8 months ago (2012-10-02 18:29:21 UTC) #3

On 2012/10/02 18:32:09, bsalomon wrote:
> LGTM

LGTM

Expand All Messages | Collapse All Messages