Issue 6595066: Created filter command line tool

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6595066: Created filter command line tool (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by robertphillips

Modified:
11 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com, tfarina1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Created filter command line tool

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -0 lines)			Patch
	M	gyp/tools.gyp	View		2 chunks	+18 lines, -0 lines	0 comments	Download
	A	tools/filtermain.cpp	View		1 chunk	+92 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

tfarina1

11 years, 8 months ago (2012-10-04 14:08:46 UTC) #4

https://codereview.appspot.com/6595066/diff/1/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6595066/diff/1/tools/filtermain.cpp#newcode21
tools/filtermain.cpp:21: int filter_main(int argc, char** argv);
how come you added this declaration? And in the next line you define/implement
it.

This is totally unnecessary!

Remove it.

https://codereview.appspot.com/6595066/diff/1/tools/filtermain.cpp#newcode23
tools/filtermain.cpp:23: 
rm blank line.

Expand All Messages | Collapse All Messages