Issue 6595047: Fixed bug in drawing of large bitmaps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6595047: Fixed bug in drawing of large bitmaps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by robertphillips

Modified:
12 years, 3 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The canvas offset code in drawTiledBitmap looked fishy but there was no test to prove it. The new test in this CL revealed the bug (initially no small rect was appearing for Ganesh) and the SkGpuDevice changes fix it.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -15 lines)			Patch
	M	gm/bitmaprect.cpp	View		1 chunk	+14 lines, -4 lines	0 comments	Download
	M	src/gpu/SkGpuDevice.cpp	View		3 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On 2012/10/01 14:08:31, robertphillips wrote: nice! lgtm.

12 years, 3 months ago (2012-10-01 14:27:03 UTC) #2

committed as r5745

Expand All Messages | Collapse All Messages