Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(220)

Issue 6594047: Issue 2869: Regularize lyrics lexer mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dak
Modified:
11 years, 5 months ago
Reviewers:
janek, lemzwerg
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

That makes lyrics mode rather similar to markup mode regarding how words are formed. {} are never considered part of words unless enclosed in quotes. Unquoted words do not contain whitespace, braces, quotes, backslashes, numbers or Scheme expressions. In addition, they cannot start with * . = and | since that would mess with duration, assignment and barcheck syntax. This removes some remaining TeX-oriented cruft in the lexer. The set of word-non-starters might need revisiting, but at least the regtests seem to pass.

Patch Set 1 #

Patch Set 2 : Add | to non-word starters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -18 lines) Patch
M lily/lexer.ll View 1 6 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM.
11 years, 6 months ago (2012-09-30 04:31:19 UTC) #1
janek
11 years, 6 months ago (2012-09-30 22:03:45 UTC) #2
I don't feel competent to speak about the code (and if i started asking
questions, it would take ages to answer them all), but the idea of the change
definitely LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b