Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2151)

Issue 6593082: Remove unnecessary function declaration. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by tfarina1
Modified:
11 years, 8 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove unnecessary function declaration. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5851

Patch Set 1 #

Patch Set 2 : make it static btw #

Patch Set 3 : add comment #

Patch Set 4 : fix typo #

Patch Set 5 : rm ////// #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tools/filtermain.cpp View 1 2 3 4 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5
tfarina1
11 years, 8 months ago (2012-10-04 14:24:19 UTC) #1
tfarina1
I think 'nonsense' was too heavy. 'unnecessary' is better. Robert, please, could you review this ...
11 years, 8 months ago (2012-10-07 23:35:38 UTC) #2
reed1
The reason filter_main is not static, is so that we can reference it externally in ...
11 years, 8 months ago (2012-10-08 12:13:54 UTC) #3
tfarina1
Added the comment. Please, take another look! Although I'd like to note that a clearer ...
11 years, 8 months ago (2012-10-08 14:37:28 UTC) #4
reed1
11 years, 8 months ago (2012-10-08 14:38:17 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b