Speculative render target ref/unref fixes

Speculative render target ref/unref fixes

[robertphillips, 2012-10-01 17:39:33]

Haven't seen these in the wild but these seem to be ref/unref omissions similar
to http://code.google.com/p/skia/source/detail?r=5734

https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h#newc...
include/gpu/GrContext.h:733: 
Re-ordered to match other entry point

https://codereview.appspot.com/6592051/diff/2001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.appspot.com/6592051/diff/2001/src/gpu/SkGpuDevice.cpp#newc...
src/gpu/SkGpuDevice.cpp:888: }
I have a clearer diff (w/ another tool) on my machine.

[bsalomon, 2012-10-01 17:46:06]

https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h#newc...
include/gpu/GrContext.h:660: GrSafeSetNull(fPrevTarget);
why set to null rather than just safe-unref?

https://codereview.appspot.com/6592051/diff/2001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.appspot.com/6592051/diff/2001/src/gpu/GrClipMaskManager.cp...
src/gpu/GrClipMaskManager.cpp:1219: GrRenderTarget* temp =
drawState->getRenderTarget();
Should we use GrDrawState::AutoRenderTargetRestore ?

https://codereview.appspot.com/6592051/diff/2001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.appspot.com/6592051/diff/2001/src/gpu/SkGpuDevice.cpp#newc...
src/gpu/SkGpuDevice.cpp:888: }
On 2012/10/01 17:39:33, robertphillips wrote:
> I have a clearer diff (w/ another tool) on my machine.

I think I was able to spot the differences... using art and ac.

[robertphillips, 2012-10-01 18:01:02]

https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h#newc...
include/gpu/GrContext.h:660: GrSafeSetNull(fPrevTarget);
On 2012/10/01 17:46:06, bsalomon wrote:
> why set to null rather than just safe-unref?

Done.

https://codereview.appspot.com/6592051/diff/2001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.appspot.com/6592051/diff/2001/src/gpu/GrClipMaskManager.cp...
src/gpu/GrClipMaskManager.cpp:1219: GrRenderTarget* temp =
drawState->getRenderTarget();
On 2012/10/01 17:46:06, bsalomon wrote:
> Should we use GrDrawState::AutoRenderTargetRestore ?

Done - clear has an internal AutoRenderTargetRestore.

[bsalomon, 2012-10-01 18:19:41]

On 2012/10/01 18:01:02, robertphillips wrote:
> https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h
> File include/gpu/GrContext.h (right):
> 
>
https://codereview.appspot.com/6592051/diff/2001/include/gpu/GrContext.h#newc...
> include/gpu/GrContext.h:660: GrSafeSetNull(fPrevTarget);
> On 2012/10/01 17:46:06, bsalomon wrote:
> > why set to null rather than just safe-unref?
> 
> Done.
> 
> https://codereview.appspot.com/6592051/diff/2001/src/gpu/GrClipMaskManager.cpp
> File src/gpu/GrClipMaskManager.cpp (right):
> 
>
https://codereview.appspot.com/6592051/diff/2001/src/gpu/GrClipMaskManager.cp...
> src/gpu/GrClipMaskManager.cpp:1219: GrRenderTarget* temp =
> drawState->getRenderTarget();
> On 2012/10/01 17:46:06, bsalomon wrote:
> > Should we use GrDrawState::AutoRenderTargetRestore ?
> 
> Done - clear has an internal AutoRenderTargetRestore.

LGTM

[robertphillips, 2012-10-01 18:25:40]

committed as r5754