Issue 6591054: retool so we don't need to call SkCanvas::setDevice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6591054: retool so we don't need to call SkCanvas::setDevice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by reed1

Modified:
12 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

retool so we don't need to call SkCanvas::setDevice Committed: https://code.google.com/p/skia/source/detail?r=5759

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -16 lines)			Patch
M	include/views/SkWindow.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	samplecode/SampleApp.h	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	src/views/SkWindow.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/views/mac/SkNSView.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3

bsalomon

12 years ago (2012-10-01 20:09:16 UTC) #3

On 2012/10/01 19:38:04, reed1 wrote:

Overall looks good... needs changes in experimental/iOSSampleApp