Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(331)

Issue 659041: inspect.getcallargs() [issue 3135]

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by George Sakkis
Modified:
12 years, 8 months ago
Reviewers:
Benjamin
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Description

A new proposed function for inspect; see http://bugs.python.org/issue3135

Patch Set 1 #

Total comments: 68

Patch Set 2 : Update after Benjamin's review #

Total comments: 6

Patch Set 3 : Final touches #

Patch Set 4 : Updated to align with the changes of r79235 and r79237 #

Patch Set 5 : Removed the obsolete (after r79235) comments in the tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -4 lines) Patch
Doc/library/inspect.rst View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
Lib/inspect.py View 1 2 3 4 2 chunks +87 lines, -1 line 0 comments Download
Lib/test/test_inspect.py View 1 2 3 4 3 chunks +195 lines, -3 lines 0 comments Download

Messages

Total messages: 7
George Sakkis
12 years, 8 months ago (2010-03-19 22:02:27 UTC) #1
Benjamin
http://codereview.appspot.com/659041/diff/1/4 File Doc/library/inspect.rst (right): http://codereview.appspot.com/659041/diff/1/4#newcode507 Doc/library/inspect.rst:507: .. function:: getcallargs(func[, *args][, **kwds]) I would like to ...
12 years, 8 months ago (2010-03-20 03:14:31 UTC) #2
George Sakkis
Thanks for taking the time to go through the whole patch Benjamin, I appreciate it. ...
12 years, 8 months ago (2010-03-20 13:26:34 UTC) #3
Benjamin
http://codereview.appspot.com/659041/diff/1/2 File Lib/inspect.py (right): http://codereview.appspot.com/659041/diff/1/2#newcode923 Lib/inspect.py:923: elif not positional or not isinstance(positional[0], func.im_class): On 2010/03/20 ...
12 years, 8 months ago (2010-03-20 16:32:15 UTC) #4
Benjamin
I think it looks mostly good now. http://codereview.appspot.com/659041/diff/13001/14001 File Doc/library/inspect.rst (right): http://codereview.appspot.com/659041/diff/13001/14001#newcode511 Doc/library/inspect.rst:511: first argument ...
12 years, 8 months ago (2010-03-20 16:49:45 UTC) #5
George Sakkis
All done, we're good to go. http://codereview.appspot.com/659041/diff/13001/14001 File Doc/library/inspect.rst (right): http://codereview.appspot.com/659041/diff/13001/14001#newcode511 Doc/library/inspect.rst:511: first argument (typically ...
12 years, 8 months ago (2010-03-20 20:48:27 UTC) #6
George Sakkis
12 years, 8 months ago (2010-03-21 21:51:54 UTC) #7
Updated to align with the changes of r79235 and r79237
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b