Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 6590070: Fix reply by email not working again

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by JohnA
Modified:
13 years, 3 months ago
Reviewers:
DO NOT USE, GvR, M-A
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

Fix reply by email not working again. This is a revert of 52daa039c058. Looks like AE had previously stopped Windows-1252 decoding which is why the earlier fix was needed. Now it looks like it does get decoded so the previous fix is backfiring.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M codereview/views.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2
JohnA
Here's a callstack that I see: UnicodeEncodeError: Traceback (most recent call last): File "/base/python27_runtime/python27_lib/versions/third_party/django-1.3/django/core/handlers/base.py", line ...
13 years, 3 months ago (2012-10-04 05:57:15 UTC) #1
M-A
13 years, 3 months ago (2012-10-04 12:42:19 UTC) #2
I'm not 100% sure on what this code is doing but I trust you about this one.

Please commit on default, then merge on chromium branch and make it live after.
Don't forget to hg pull -u first, as it looks like you were one revision late.

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b