Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(796)

Issue 6590068: Allow Xcode to change paths to frameworks based on whether a device or simulator was selected. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bsalomon
Modified:
12 years, 2 months ago
Reviewers:
caryclark1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Allow Xcode to change paths to frameworks based on whether a device or simulator was selected. R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=5802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -35 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +9 lines, -9 lines 0 comments Download
M gyp/SimpleiOSApp.gyp View 1 chunk +6 lines, -6 lines 0 comments Download
M gyp/apptype_console.gypi View 1 chunk +6 lines, -6 lines 0 comments Download
M gyp/common_variables.gypi View 2 chunks +1 line, -4 lines 0 comments Download
M gyp/core.gyp View 1 chunk +9 lines, -9 lines 0 comments Download
M gyp/zlib.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bsalomon
Cary, this allows me to switch between device and sim without re-gyping. Can you test ...
12 years, 2 months ago (2012-10-03 21:59:36 UTC) #1
caryclark1
lgtm Building on XCode 3 generates the warning: "iOS deployment target '6.0' for architecture 'armv7' ...
12 years, 2 months ago (2012-10-04 11:51:18 UTC) #2
bsalomon
12 years, 2 months ago (2012-10-04 12:42:11 UTC) #3
On 2012/10/04 11:51:18, caryclark1 wrote:
> lgtm
> 
> Building on XCode 3 generates the warning: "iOS deployment target '6.0' for
> architecture 'armv7' and variant 'normal' is greater than the maximum value
> '4.3.99' for the iOS 4.3 SDK." But -- this may be a total red herring -- since
> my build before and after your change hangs in Interface Builder and is
> nonfunctional, it may be wonky about the deployment target as well.

Hmm... maybe you need to set "ios_sdk_version=4.3" in GYP_DEFINES for Xcode3?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b