Issue 6590050: Adding virtual method to SkDeferredCanvas::NotificationClient for signaling when commands are skipp…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6590050: Adding virtual method to SkDeferredCanvas::NotificationClient for signaling when commands are skipp… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by junov1

Modified:
11 years, 11 months ago

Reviewers:
junov, reed1

CC:
skia-review_googlegroups.com, senorblanco

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adding virtual method to SkDeferredCanvas::NotificationClient for signaling when commands are skipped due to the skip on clear optimization. TEST=DeferredCanvas unit test BUG=http://code.google.com/p/chromium/issues/detail?id=116840 Committed: https://code.google.com/p/skia/source/detail?r=5747

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -1 line)			Patch
M	include/utils/SkDeferredCanvas.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/utils/SkDeferredCanvas.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/DeferredCanvasTest.cpp	View	3 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm, but what is the intended use? I can't tell off-hand from the cited bug ...

11 years, 11 months ago (2012-10-01 15:07:53 UTC) #2

junov

11 years, 11 months ago (2012-10-01 15:21:29 UTC) #3

On 2012/10/01 15:07:53, reed1 wrote:
> lgtm, but what is the intended use? I can't tell off-hand from the cited bug
how
> this callback will help.

:-) It is in response to review comments that are in the associated webkit bug:
https://bugs.webkit.org/show_bug.cgi?id=97918

Expand All Messages | Collapse All Messages