Issue 6589062: Allow render_pictures to render using multiple threads.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6589062: Allow render_pictures to render using multiple threads. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Leon

Modified:
12 years, 3 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Allow render_pictures to render using multiple threads. Make write() a static function so it can be used by the thread entry functions. Add a helper function to append a number to a string and call write to share code. Committed: https://code.google.com/p/skia/source/detail?r=5789

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -99 lines)			Patch
M	tools/PictureRenderer.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View		12 chunks	+67 lines, -31 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View	1 2	6 chunks	+111 lines, -61 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

lgtm https://codereview.appspot.com/6589062/diff/1/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.appspot.com/6589062/diff/1/tools/render_pictures_main.cpp#newcode29 tools/render_pictures_main.cpp:29: " [--multi numThreads]\n" would this be better named ...

12 years, 3 months ago (2012-10-02 21:00:58 UTC) #2

Leon

12 years, 3 months ago (2012-10-03 17:29:29 UTC) #3

https://codereview.appspot.com/6589062/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6589062/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:29: "     [--multi numThreads]\n"
On 2012/10/02 21:00:58, DerekS wrote:
> would this be better named --threads count?

Yes. Done

Expand All Messages | Collapse All Messages