Issue 6588078: Adding proxy_info_from_* methods to Python3. (Closed)
|
Created:
12 years, 2 months ago by dhermes Modified:
12 years, 1 month ago CC:
httlib2-dev_googlegroups.com Visibility:
Public. |
DescriptionAdding proxy_info_from_* methods to Python3.
Patch Set 1 #Patch Set 2 : Adding reviewers #
MessagesTotal messages: 12
lgtm
Sign in to reply to this message.
Thanks. I don't have commit privileges. On Thu, Oct 11, 2012 at 10:50 AM, <jcgregorio@google.com> wrote: > lgtm > > > https://codereview.appspot.**com/6588078/<https://codereview.appspot.com/6588... > -- Danny Hermes Developer Programs Engineer
Sign in to reply to this message.
On 2012/10/11 17:50:00, jcgregorio_google wrote: > lgtm hg qimport failed to apply this patch. Are you synced to head?
Sign in to reply to this message.
On 2012/10/11 18:00:44, jcgregorio_google wrote: > On 2012/10/11 17:50:00, jcgregorio_google wrote: > > lgtm > > hg qimport failed to apply this patch. Are you synced to head? Yes I am synced to HEAD.
Sign in to reply to this message.
It's unclear why this and the last uploaded in this way but I also can't qimport on a clean repo. I made on by hand that works via manually application "hg import --no-commit". Find it attached. On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: > On 2012/10/11 18:00:44, jcgregorio_google wrote: > >> On 2012/10/11 17:50:00, jcgregorio_google wrote: >> > lgtm >> > > hg qimport failed to apply this patch. Are you synced to head? >> > > Yes I am synced to HEAD. > > https://codereview.appspot.**com/6588078/<https://codereview.appspot.com/6588... > -- Danny Hermes Developer Programs Engineer
Sign in to reply to this message.
I did not find it attached :( On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> wrote: > It's unclear why this and the last uploaded in this way but I also can't > qimport on a clean repo. I made on by hand that works via manually > application "hg import --no-commit". > > Find it attached. > > > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: >> >> On 2012/10/11 18:00:44, jcgregorio_google wrote: >>> >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: >>> > lgtm >> >> >>> hg qimport failed to apply this patch. Are you synced to head? >> >> >> Yes I am synced to HEAD. >> >> https://codereview.appspot.com/6588078/ > > > > > -- > Danny Hermes > Developer Programs Engineer
Sign in to reply to this message.
Strange here it is again. On Fri, Oct 12, 2012 at 9:47 AM, Joe Gregorio <jcgregorio@google.com> wrote: > I did not find it attached :( > > On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> wrote: > > It's unclear why this and the last uploaded in this way but I also can't > > qimport on a clean repo. I made on by hand that works via manually > > application "hg import --no-commit". > > > > Find it attached. > > > > > > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: > >> > >> On 2012/10/11 18:00:44, jcgregorio_google wrote: > >>> > >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: > >>> > lgtm > >> > >> > >>> hg qimport failed to apply this patch. Are you synced to head? > >> > >> > >> Yes I am synced to HEAD. > >> > >> https://codereview.appspot.com/6588078/ > > > > > > > > > > -- > > Danny Hermes > > Developer Programs Engineer > -- Danny Hermes Developer Programs Engineer
Sign in to reply to this message.
Any issues getting this diff to import? On Fri, Oct 12, 2012 at 1:49 PM, Danny Hermes <dhermes@google.com> wrote: > Strange here it is again. > > > On Fri, Oct 12, 2012 at 9:47 AM, Joe Gregorio <jcgregorio@google.com>wrote: > >> I did not find it attached :( >> >> On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> wrote: >> > It's unclear why this and the last uploaded in this way but I also can't >> > qimport on a clean repo. I made on by hand that works via manually >> > application "hg import --no-commit". >> > >> > Find it attached. >> > >> > >> > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: >> >> >> >> On 2012/10/11 18:00:44, jcgregorio_google wrote: >> >>> >> >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: >> >>> > lgtm >> >> >> >> >> >>> hg qimport failed to apply this patch. Are you synced to head? >> >> >> >> >> >> Yes I am synced to HEAD. >> >> >> >> https://codereview.appspot.com/6588078/ >> > >> > >> > >> > >> > -- >> > Danny Hermes >> > Developer Programs Engineer >> > > > > -- > Danny Hermes > Developer Programs Engineer > -- Danny Hermes Developer Programs Engineer
Sign in to reply to this message.
-httlib2-dev@googlegroups.com (This autofills with a typo) Any issues getting this to import now? On Mon, Oct 15, 2012 at 8:59 PM, Danny Hermes <dhermes@google.com> wrote: > Any issues getting this diff to import? > > > On Fri, Oct 12, 2012 at 1:49 PM, Danny Hermes <dhermes@google.com> wrote: > >> Strange here it is again. >> >> >> On Fri, Oct 12, 2012 at 9:47 AM, Joe Gregorio <jcgregorio@google.com>wrote: >> >>> I did not find it attached :( >>> >>> On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> >>> wrote: >>> > It's unclear why this and the last uploaded in this way but I also >>> can't >>> > qimport on a clean repo. I made on by hand that works via manually >>> > application "hg import --no-commit". >>> > >>> > Find it attached. >>> > >>> > >>> > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: >>> >> >>> >> On 2012/10/11 18:00:44, jcgregorio_google wrote: >>> >>> >>> >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: >>> >>> > lgtm >>> >> >>> >> >>> >>> hg qimport failed to apply this patch. Are you synced to head? >>> >> >>> >> >>> >> Yes I am synced to HEAD. >>> >> >>> >> https://codereview.appspot.com/6588078/ >>> > >>> > >>> > >>> > >>> > -- >>> > Danny Hermes >>> > Developer Programs Engineer >>> >> >> >> >> -- >> Danny Hermes >> Developer Programs Engineer >> > > > > -- > Danny Hermes > Developer Programs Engineer > -- Danny Hermes Developer Programs Engineer
Sign in to reply to this message.
Committed at: http://code.google.com/p/httplib2/source/detail?r=75f76ff8e6ecbd90b210d80068b... Was having issues running the unit tests, but that was an issue with the endpoint they run against. Thanks, -joe On Wed, Oct 24, 2012 at 5:01 PM, Danny Hermes <dhermes@google.com> wrote: > -httlib2-dev@googlegroups.com (This autofills with a typo) > > Any issues getting this to import now? > > > On Mon, Oct 15, 2012 at 8:59 PM, Danny Hermes <dhermes@google.com> wrote: >> >> Any issues getting this diff to import? >> >> >> On Fri, Oct 12, 2012 at 1:49 PM, Danny Hermes <dhermes@google.com> wrote: >>> >>> Strange here it is again. >>> >>> >>> On Fri, Oct 12, 2012 at 9:47 AM, Joe Gregorio <jcgregorio@google.com> >>> wrote: >>>> >>>> I did not find it attached :( >>>> >>>> On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> >>>> wrote: >>>> > It's unclear why this and the last uploaded in this way but I also >>>> > can't >>>> > qimport on a clean repo. I made on by hand that works via manually >>>> > application "hg import --no-commit". >>>> > >>>> > Find it attached. >>>> > >>>> > >>>> > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: >>>> >> >>>> >> On 2012/10/11 18:00:44, jcgregorio_google wrote: >>>> >>> >>>> >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: >>>> >>> > lgtm >>>> >> >>>> >> >>>> >>> hg qimport failed to apply this patch. Are you synced to head? >>>> >> >>>> >> >>>> >> Yes I am synced to HEAD. >>>> >> >>>> >> https://codereview.appspot.com/6588078/ >>>> > >>>> > >>>> > >>>> > >>>> > -- >>>> > Danny Hermes >>>> > Developer Programs Engineer >>> >>> >>> >>> >>> -- >>> Danny Hermes >>> Developer Programs Engineer >> >> >> >> >> -- >> Danny Hermes >> Developer Programs Engineer > > > > > -- > Danny Hermes > Developer Programs Engineer
Sign in to reply to this message.
Cool. Thanks Joe! Do you mind if I do a lint only change to httplib2? On Thu, Oct 25, 2012 at 11:08 AM, Joe Gregorio <jcgregorio@google.com>wrote: > Committed at: > > > http://code.google.com/p/httplib2/source/detail?r=75f76ff8e6ecbd90b210d80068b... > > Was having issues running the unit tests, but that was an issue with > the endpoint they run against. > > Thanks, > -joe > > > > On Wed, Oct 24, 2012 at 5:01 PM, Danny Hermes <dhermes@google.com> wrote: > > -httlib2-dev@googlegroups.com (This autofills with a typo) > > > > Any issues getting this to import now? > > > > > > On Mon, Oct 15, 2012 at 8:59 PM, Danny Hermes <dhermes@google.com> > wrote: > >> > >> Any issues getting this diff to import? > >> > >> > >> On Fri, Oct 12, 2012 at 1:49 PM, Danny Hermes <dhermes@google.com> > wrote: > >>> > >>> Strange here it is again. > >>> > >>> > >>> On Fri, Oct 12, 2012 at 9:47 AM, Joe Gregorio <jcgregorio@google.com> > >>> wrote: > >>>> > >>>> I did not find it attached :( > >>>> > >>>> On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> > >>>> wrote: > >>>> > It's unclear why this and the last uploaded in this way but I also > >>>> > can't > >>>> > qimport on a clean repo. I made on by hand that works via manually > >>>> > application "hg import --no-commit". > >>>> > > >>>> > Find it attached. > >>>> > > >>>> > > >>>> > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: > >>>> >> > >>>> >> On 2012/10/11 18:00:44, jcgregorio_google wrote: > >>>> >>> > >>>> >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: > >>>> >>> > lgtm > >>>> >> > >>>> >> > >>>> >>> hg qimport failed to apply this patch. Are you synced to head? > >>>> >> > >>>> >> > >>>> >> Yes I am synced to HEAD. > >>>> >> > >>>> >> https://codereview.appspot.com/6588078/ > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > -- > >>>> > Danny Hermes > >>>> > Developer Programs Engineer > >>> > >>> > >>> > >>> > >>> -- > >>> Danny Hermes > >>> Developer Programs Engineer > >> > >> > >> > >> > >> -- > >> Danny Hermes > >> Developer Programs Engineer > > > > > > > > > > -- > > Danny Hermes > > Developer Programs Engineer > -- Danny Hermes Developer Programs Engineer
Sign in to reply to this message.
On Thu, Oct 25, 2012 at 2:13 PM, Danny Hermes <dhermes@google.com> wrote: > Cool. Thanks Joe! > > Do you mind if I do a lint only change to httplib2? Sure, go ahead. Thanks, -joe > > > > On Thu, Oct 25, 2012 at 11:08 AM, Joe Gregorio <jcgregorio@google.com> > wrote: >> >> Committed at: >> >> >> http://code.google.com/p/httplib2/source/detail?r=75f76ff8e6ecbd90b210d80068b... >> >> Was having issues running the unit tests, but that was an issue with >> the endpoint they run against. >> >> Thanks, >> -joe >> >> >> >> On Wed, Oct 24, 2012 at 5:01 PM, Danny Hermes <dhermes@google.com> wrote: >> > -httlib2-dev@googlegroups.com (This autofills with a typo) >> > >> > Any issues getting this to import now? >> > >> > >> > On Mon, Oct 15, 2012 at 8:59 PM, Danny Hermes <dhermes@google.com> >> > wrote: >> >> >> >> Any issues getting this diff to import? >> >> >> >> >> >> On Fri, Oct 12, 2012 at 1:49 PM, Danny Hermes <dhermes@google.com> >> >> wrote: >> >>> >> >>> Strange here it is again. >> >>> >> >>> >> >>> On Fri, Oct 12, 2012 at 9:47 AM, Joe Gregorio <jcgregorio@google.com> >> >>> wrote: >> >>>> >> >>>> I did not find it attached :( >> >>>> >> >>>> On Fri, Oct 12, 2012 at 1:27 PM, Danny Hermes <dhermes@google.com> >> >>>> wrote: >> >>>> > It's unclear why this and the last uploaded in this way but I also >> >>>> > can't >> >>>> > qimport on a clean repo. I made on by hand that works via manually >> >>>> > application "hg import --no-commit". >> >>>> > >> >>>> > Find it attached. >> >>>> > >> >>>> > >> >>>> > On Thu, Oct 11, 2012 at 10:01 AM, <dhermes@google.com> wrote: >> >>>> >> >> >>>> >> On 2012/10/11 18:00:44, jcgregorio_google wrote: >> >>>> >>> >> >>>> >>> On 2012/10/11 17:50:00, jcgregorio_google wrote: >> >>>> >>> > lgtm >> >>>> >> >> >>>> >> >> >>>> >>> hg qimport failed to apply this patch. Are you synced to head? >> >>>> >> >> >>>> >> >> >>>> >> Yes I am synced to HEAD. >> >>>> >> >> >>>> >> https://codereview.appspot.com/6588078/ >> >>>> > >> >>>> > >> >>>> > >> >>>> > >> >>>> > -- >> >>>> > Danny Hermes >> >>>> > Developer Programs Engineer >> >>> >> >>> >> >>> >> >>> >> >>> -- >> >>> Danny Hermes >> >>> Developer Programs Engineer >> >> >> >> >> >> >> >> >> >> -- >> >> Danny Hermes >> >> Developer Programs Engineer >> > >> > >> > >> > >> > -- >> > Danny Hermes >> > Developer Programs Engineer > > > > > -- > Danny Hermes > Developer Programs Engineer
Sign in to reply to this message.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
