Issue 6588062: xocde_settings OTHER_CPLUSPLUSFLAGS is a list.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6588062: xocde_settings OTHER_CPLUSPLUSFLAGS is a list. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bungeman

Modified:
11 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

This corrects a Skia gypi so that ninja can be used on Mac.

11 years, 9 months ago (2012-10-02 15:27:45 UTC) #1

reed1

If this is to make ninja work, we should say that in the CL, or ...

11 years, 9 months ago (2012-10-02 15:31:26 UTC) #2

bungeman

11 years, 9 months ago (2012-10-02 15:45:33 UTC) #3

Committed revision 5769.

OTHER_CPLUSPLUSFLAGS appears to have always been a list, we were just getting
lucky with the xcode generator. The ninja generator isn't quite so forgiving.

Expand All Messages | Collapse All Messages