Issue 6588055: Fixed cross compilation with mingw

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6588055: Fixed cross compilation with mingw

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by jacek

Modified:
12 years, 1 month ago

Reviewers:
bungeman

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fixed cross compilation with mingw It's a trivial problem: when cross compiling on case sensitive OS, DWrite.h is not found. MinGW uses lower case for all includes. I've already fixed similar problem with usp10.h in the past: http://codereview.appspot.com/5444044/ BUG=897

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkAdvancedTypefaceMetrics.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jacek

On 2012/10/05 08:26:39, jacek wrote: > Ping, can this be committed? Please, it's really trivial. ...

12 years, 1 month ago (2012-10-30 08:36:45 UTC) #4

bungeman

12 years, 1 month ago (2012-10-30 14:16:39 UTC) #6

lgtm

Note that dwrite.h is already lowercase in SkFontHost_win_dw.cpp, I'm not sure
why this one was different.

Committed revision 6197.

Expand All Messages | Collapse All Messages