Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3372)

Issue 6587057: Fix DAG connectivity for morphology filter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Stephen White
Modified:
12 years, 1 month ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When processing a morphology filter on the GPU, pass the processed texture, not the original source texture. This doesn't affect Chrome, since it doesn't use the skia filter DAG yet. (I probably broke this in r5241, and it would've been caught by gm/imagefiltersgraph.cpp, but we don't have any baselines for it. :/)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
src/effects/SkMorphologyImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Stephen White
12 years, 1 month ago (2012-10-01 22:28:34 UTC) #1
robertphillips
LGTM
12 years, 1 month ago (2012-10-02 00:24:30 UTC) #2
Stephen White
12 years, 1 month ago (2012-10-03 16:50:10 UTC) #3
On 2012/10/02 00:24:30, robertphillips wrote:
> LGTM

Landed as https://code.google.com/p/skia/source/detail?r=5766.  Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b