Make numTextures() be non-virtual on GrCustomStage

Make numTextures() be non-virtual on GrCustomStage.

R=tomhudson@google.com,robertphillips@google.com,senorblanco@chromium.org
Committed: https://code.google.com/p/skia/source/detail?r=5805

[bsalomon, 2012-10-04 14:09:03]

We have at least one place where we loop like this:

for (int i = 0; i < stage->numTextures(); ++i) { // AHhhh! virtual call!

Rather than keep on top of it, it seems easier to me to make the function
inline. We already require that GrCustomStages are immutable after creation, so
it doesn't seem onerous to know at construction time how many textures you'll be
using. It may nudge a CS author to use a factory function rather than a complex
constructor, which doesn't seem like a bad thing to me.

[Stephen White, 2012-10-04 14:13:48]

https://codereview.appspot.com/6586081/diff/1001/include/gpu/GrCustomStage.h
File include/gpu/GrCustomStage.h (right):

https://codereview.appspot.com/6586081/diff/1001/include/gpu/GrCustomStage.h#...
include/gpu/GrCustomStage.h:38: GrCustomStage(int numTextures);
explicit?

https://codereview.appspot.com/6586081/diff/1001/src/effects/gradients/SkGrad...
File src/effects/gradients/SkGradientShader.cpp (right):

https://codereview.appspot.com/6586081/diff/1001/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShader.cpp:769: GrAssert(index);
I'm missing something.. shouldn't this still be GrAssert(0 == index)?

https://codereview.appspot.com/6586081/diff/1001/src/gpu/effects/GrColorTable...
File src/gpu/effects/GrColorTableEffect.h (left):

https://codereview.appspot.com/6586081/diff/1001/src/gpu/effects/GrColorTable...
src/gpu/effects/GrColorTableEffect.h:24: GrColorTableEffect(GrTexture* texture);
Not new in this change, but this should probably be explicit too.

[bsalomon, 2012-10-04 14:17:46]

https://codereview.appspot.com/6586081/diff/1001/include/gpu/GrCustomStage.h
File include/gpu/GrCustomStage.h (right):

https://codereview.appspot.com/6586081/diff/1001/include/gpu/GrCustomStage.h#...
include/gpu/GrCustomStage.h:38: GrCustomStage(int numTextures);
On 2012/10/04 14:13:48, Stephen White wrote:
> explicit?

Done.

https://codereview.appspot.com/6586081/diff/1001/src/effects/gradients/SkGrad...
File src/effects/gradients/SkGradientShader.cpp (right):

https://codereview.appspot.com/6586081/diff/1001/src/effects/gradients/SkGrad...
src/effects/gradients/SkGradientShader.cpp:769: GrAssert(index);
On 2012/10/04 14:13:48, Stephen White wrote:
> I'm missing something.. shouldn't this still be GrAssert(0 == index)?
That's what I get for only running the release build. Done.

https://codereview.appspot.com/6586081/diff/1001/src/gpu/effects/GrColorTable...
File src/gpu/effects/GrColorTableEffect.h (left):

https://codereview.appspot.com/6586081/diff/1001/src/gpu/effects/GrColorTable...
src/gpu/effects/GrColorTableEffect.h:24: GrColorTableEffect(GrTexture* texture);
On 2012/10/04 14:13:48, Stephen White wrote:
> Not new in this change, but this should probably be explicit too.

Done.

[robertphillips, 2012-10-04 14:24:51]

LGTM

[Stephen White, 2012-10-04 14:33:05]

LGTM too

[TomH, 2012-10-04 14:36:28]

Aha, with a member on the base class. Back to the original design!

(LGTM)