Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(404)

Issue 6586072: cmd/5g: fix out of registers in nested calls, add compi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by remyoudompheng
Modified:
9 years, 12 months ago
Reviewers:
CC:
golang-dev, dfc, DMorsing, rsc, remy_archlinux.org
Visibility:
Public.

Description

cmd/5g: fix out of registers in nested calls, add compiler torture test.

Patch Set 1 #

Patch Set 2 : diff -r 2a8dfbc7b566 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2a8dfbc7b566 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c6f9c0f01c09 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -7 lines) Patch
M src/cmd/5g/cgen.c View 1 3 chunks +17 lines, -7 lines 0 comments Download
A test/torture.go View 1 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 8
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 12 months ago (2012-10-03 21:33:29 UTC) #1
remyoudompheng
My original intention was to only submit the torture test. It happens that it uncovered ...
9 years, 12 months ago (2012-10-03 21:34:25 UTC) #2
dfc
Thank you, I will test this today. On 4 Oct 2012 07:34, <remyoudompheng@gmail.com> wrote: > ...
9 years, 12 months ago (2012-10-03 21:58:52 UTC) #3
dfc
LGTM linux/arm, GOARM=5
9 years, 12 months ago (2012-10-04 00:46:55 UTC) #4
remyoudompheng
Thanks, I'll wait for feedback about the test itself.
9 years, 12 months ago (2012-10-04 06:33:59 UTC) #5
DMorsing
Torture test LGTM. Alternating chain expressions might be useful if we start doing AST folding, ...
9 years, 12 months ago (2012-10-04 06:55:01 UTC) #6
rsc
LGTM
9 years, 12 months ago (2012-10-05 21:19:13 UTC) #7
remyoudompheng
9 years, 12 months ago (2012-10-05 21:30:56 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=591de8123cb5 ***

cmd/5g: fix out of registers in nested calls, add compiler torture test.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6586072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b