Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1817)

Issue 6585082: Omit shader swizzle if it is rgba. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by bsalomon
Modified:
11 years, 11 months ago
Reviewers:
robertphilips, robertphillips, TomH
CC:
Stephen White, skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Omit shader swizzle if it is rgba. R=robertphilips@google.com Committed: https://code.google.com/p/skia/source/detail?r=5804

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 2 3 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 5
bsalomon
Stephen rightly complains that our shaders have .rgba all over them. To work around a ...
11 years, 11 months ago (2012-10-04 13:17:41 UTC) #1
TomH
LGTM
11 years, 11 months ago (2012-10-04 13:19:31 UTC) #2
robertphillips
LGTM
11 years, 11 months ago (2012-10-04 14:07:03 UTC) #3
TomH
OK, phew - I saw that R= go through on the commit, and was thinking ...
11 years, 11 months ago (2012-10-04 14:08:17 UTC) #4
bsalomon
11 years, 11 months ago (2012-10-04 14:12:24 UTC) #5
On 2012/10/04 14:08:17, TomH wrote:
> OK, phew - I saw that R= go through on the commit, and was thinking that the
> haircut wasn't extreme enough for me to be mistaken for Rob.

Oh hmm... I didn't think about that . I've been sticking R= lines in my gcl CL
description so I don't have to type reviewers names on codereview. Maybe that's
a mistake unless I remember to edit them later. In any event I've now spent more
energy typing this comment than I've saved using R= so I better quit.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b