Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 6585063: code review 6585063: go/ast: track position of <- for channel types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by gri
Modified:
9 years, 12 months ago
Reviewers:
CC:
iant, iant2, golang-dev
Visibility:
Public.

Description

go/ast: track position of <- for channel types This is a backward-compatible API change. Without the correct <- position information, certain channel types have incorrect position information.

Patch Set 1 #

Patch Set 2 : diff -r ae0699dbd14d https://code.google.com/p/go #

Patch Set 3 : diff -r c763565f31ff https://code.google.com/p/go #

Patch Set 4 : diff -r c763565f31ff https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M src/pkg/go/ast/ast.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/go/parser/parser.go View 1 3 chunks +13 lines, -15 lines 0 comments Download
M src/pkg/go/parser/short_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/nodes.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
gri
Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 12 months ago (2012-10-03 00:38:59 UTC) #1
iant2
LGTM On Tue, Oct 2, 2012 at 5:38 PM, <gri@golang.org> wrote: > Reviewers: iant, > ...
9 years, 12 months ago (2012-10-03 00:47:34 UTC) #2
gri
9 years, 12 months ago (2012-10-03 00:50:43 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3ae6c87de7f2 ***

go/ast: track position of <- for channel types

This is a backward-compatible API change.

Without the correct <- position information,
certain channel types have incorrect position
information.

R=iant, iant
CC=golang-dev
http://codereview.appspot.com/6585063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b