Issue 6582043: Make gpu work in iOS SampleApp.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6582043: Make gpu work in iOS SampleApp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bsalomon

Modified:
12 years, 2 months ago

Reviewers:
caryclark1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make gpu work in iOS SampleApp. This includes updates to the GrGLInterface and changes to the DeviceManager subclass used on iOS.

Patch Set 3 : #

Total comments: 2

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -160 lines)			Patch
M	experimental/iOSSampleApp/SkSampleUIView.mm	View	1 2	6 chunks	+14 lines, -13 lines	2 comments	Download
M	gyp/gpu.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/gpu.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
D	src/gpu/ios/GrGLDefaultInterface_iOS.cpp	View		1 chunk	+0 lines, -142 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

LGTM https://codereview.appspot.com/6582043/diff/4001/experimental/iOSSampleApp/SkSampleUIView.mm File experimental/iOSSampleApp/SkSampleUIView.mm (right): https://codereview.appspot.com/6582043/diff/4001/experimental/iOSSampleApp/SkSampleUIView.mm#newcode151 experimental/iOSSampleApp/SkSampleUIView.mm:151: if (fCurContext) { NULL != ?

12 years, 2 months ago (2012-09-28 16:51:37 UTC) #3

bsalomon

12 years, 2 months ago (2012-09-28 16:56:34 UTC) #4

https://codereview.appspot.com/6582043/diff/4001/experimental/iOSSampleApp/Sk...
File experimental/iOSSampleApp/SkSampleUIView.mm (right):

https://codereview.appspot.com/6582043/diff/4001/experimental/iOSSampleApp/Sk...
experimental/iOSSampleApp/SkSampleUIView.mm:151: if (fCurContext) {
On 2012/09/28 16:51:37, robertphillips wrote:
> NULL != ?

Done (here and a few other places).

Expand All Messages | Collapse All Messages