Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(425)

Issue 6575059: Proxy fixes for SkImageFilter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Stephen White
Modified:
12 years, 2 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix recursive GPU processing for ImageFilters. Plumb through the SkImageFilter::Proxy parameter to the GPU recursion path. Extract DeviceImageFilterProxy from SkCanvas.cpp into its own .h, and rename it. Background: when a filter which implements onFilterImageGPU() calls a filter which doesn't, it passes a NULL Proxy. This means that we switch to software rasterization for that filter, and never go back. The fix is to construct an SkDeviceImageFilterProxy from the SkGpuDevice, and pass that into onFilterImageGPU().

Patch Set 1 #

Patch Set 2 : add include guards, remove unused proxy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -55 lines) Patch
M include/core/SkDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlendImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M include/effects/SkSingleInputImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +3 lines, -25 lines 0 comments Download
A src/core/SkDeviceImageFilterProxy.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
src/effects/SkMorphologyImageFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkSingleInputImageFilter.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 6 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5
Stephen White
12 years, 2 months ago (2012-09-27 19:52:33 UTC) #1
reed1
interface: lgtm
12 years, 2 months ago (2012-09-27 20:28:49 UTC) #2
Stephen White
On 2012/09/27 20:28:49, reed1 wrote: > interface: lgtm Brian, would you like to take a ...
12 years, 2 months ago (2012-09-27 21:19:06 UTC) #3
bsalomon
looks perf to me. I mean perf good to me.... I mean lgtm. On Thu, ...
12 years, 2 months ago (2012-09-27 21:52:42 UTC) #4
Stephen White
12 years, 2 months ago (2012-09-27 23:52:22 UTC) #5
On 2012/09/27 21:52:42, bsalomon wrote:
> looks perf to me. I mean perf good to me.... I mean lgtm.

Perf you very perf.  I mean, thanks.  :)

Landed in https://code.google.com/p/skia/source/detail?r=5720.  Closing.
> 
> 
> On Thu, Sep 27, 2012 at 5:19 PM, <mailto:senorblanco@chromium.org> wrote:
> 
> > On 2012/09/27 20:28:49, reed1 wrote:
> >
> >> interface: lgtm
> >>
> >
> > Brian, would you like to take a look at the GPU bits?
> >
> >
>
https://codereview.appspot.**com/6575059/%3Chttps://codereview.appspot.com/65...>
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b