Issue 6575052: Pinspect and bench_pictures are crashing when invoked with no arguments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6575052: Pinspect and bench_pictures are crashing when invoked with no arguments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by fmalita

Modified:
11 years, 9 months ago

Reviewers:
Leon, fmalita1, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Pinspect and bench_pictures are crashing when invoked with no arguments. R=reed@google.com,scroggo@google.com BUG= Committed: https://code.google.com/p/skia/source/detail?r=5706

Patch Set 2 : Updated per comments. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tools/bench_pictures_main.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/pinspect.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Leon

https://codereview.appspot.com/6575052/diff/1/tools/bench_pictures_main.cpp File tools/bench_pictures_main.cpp (right): https://codereview.appspot.com/6575052/diff/1/tools/bench_pictures_main.cpp#newcode404 tools/bench_pictures_main.cpp:404: if (inputs->count() < 1) { We should also call: ...

11 years, 9 months ago (2012-09-26 21:30:27 UTC) #2

fmalita1

On 2012/09/26 21:30:27, scroggo-work wrote: > https://codereview.appspot.com/6575052/diff/1/tools/bench_pictures_main.cpp#newcode404 > tools/bench_pictures_main.cpp:404: if (inputs->count() < 1) { > ...

11 years, 9 months ago (2012-09-26 21:38:28 UTC) #3

lgtm

Expand All Messages | Collapse All Messages