Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(251)

Issue 6572047: samplecode: Avoid temporary variables of SkString type. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by tfarina1
Modified:
11 years, 8 months ago
Reviewers:
epoger, TomH
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

samplecode: Avoid temporary variables of SkString type. Just like most of the other samples, just pass the name of the sample directly. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=5743

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M samplecode/SamplePatch.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M samplecode/SamplePolyToPoly.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleTextAlpha.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleTextBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +2 lines, -4 lines 1 comment Download

Messages

Total messages: 2
tfarina1
https://codereview.appspot.com/6572047/diff/1/samplecode/SampleVertices.cpp File samplecode/SampleVertices.cpp (right): https://codereview.appspot.com/6572047/diff/1/samplecode/SampleVertices.cpp#newcode128 samplecode/SampleVertices.cpp:128: // fCurrX = click->fICurr.fX; Is it ok to remove ...
11 years, 8 months ago (2012-09-25 21:57:01 UTC) #1
TomH
11 years, 8 months ago (2012-09-29 12:16:57 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b