Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(381)

Issue 6568054: Fix update-doxygen, which fails when skia-autogen is reset (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by EricB
Modified:
11 years, 8 months ago
Reviewers:
DerekS, epoger, rmistry, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/
Visibility:
Public.

Description

Fix update-doxygen, which fails when skia-autogen is reset static_footer.txt was removed from skia/docs in r2837, but update-doxygen.sh requires it to exist in skia-autogen. If skia-autogen is cleared (frequently), then static_footer.txt can't be found. Add it back to trunk/tools and manually copy it if needed. Committed: https://code.google.com/p/skia/source/detail?r=5694

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
A trunk/tools/doxygen_footer.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M trunk/tools/update-doxygen.sh View 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
EricB
11 years, 8 months ago (2012-09-26 15:25:30 UTC) #1
TomH
Concept/plan LGTM. Get somebody else to sign off on the scripting?
11 years, 8 months ago (2012-09-26 15:28:40 UTC) #2
EricB
cc djsollen@
11 years, 8 months ago (2012-09-26 15:35:52 UTC) #3
DerekS
https://codereview.appspot.com/6568054/diff/1/trunk/tools/update-doxygen.sh File trunk/tools/update-doxygen.sh (right): https://codereview.appspot.com/6568054/diff/1/trunk/tools/update-doxygen.sh#newcode34 trunk/tools/update-doxygen.sh:34: TOOLS_DIR="$(cd "$(dirname "$0" )" && pwd )" seems like ...
11 years, 8 months ago (2012-09-26 15:58:55 UTC) #4
EricB
https://codereview.appspot.com/6568054/diff/1/trunk/tools/update-doxygen.sh File trunk/tools/update-doxygen.sh (right): https://codereview.appspot.com/6568054/diff/1/trunk/tools/update-doxygen.sh#newcode34 trunk/tools/update-doxygen.sh:34: TOOLS_DIR="$(cd "$(dirname "$0" )" && pwd )" On 2012/09/26 ...
11 years, 8 months ago (2012-09-26 16:03:24 UTC) #5
DerekS
11 years, 8 months ago (2012-09-26 16:09:11 UTC) #6
lgtm on the shell script
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b