Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(330)

Issue 6567077: code review 6567077: tiff: support writing files with differencing predictor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by bsiegert
Modified:
9 years, 9 months ago
Reviewers:
CC:
nigeltao, golang-dev
Visibility:
Public.

Description

tiff: support writing files with differencing predictor. This will make more sense after implementing compression.

Patch Set 1 #

Patch Set 2 : diff -r 097023221894 https://code.google.com/p/go.image #

Patch Set 3 : diff -r 097023221894 https://code.google.com/p/go.image #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -27 lines) Patch
M tiff/writer.go View 1 5 chunks +50 lines, -21 lines 0 comments Download
M tiff/writer_test.go View 1 2 chunks +12 lines, -6 lines 1 comment Download

Messages

Total messages: 3
bsiegert
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.image
10 years ago (2012-09-28 20:38:38 UTC) #1
nigeltao
LGTM. Submitting... https://codereview.appspot.com/6567077/diff/2002/tiff/writer_test.go File tiff/writer_test.go (right): https://codereview.appspot.com/6567077/diff/2002/tiff/writer_test.go#newcode22 tiff/writer_test.go:22: //{"video-001.tiff", &Options{Compression: Deflate}}, Delete these for now. ...
9 years, 12 months ago (2012-10-03 00:10:34 UTC) #2
nigeltao
9 years, 12 months ago (2012-10-03 00:12:25 UTC) #3
*** Submitted as
http://code.google.com/p/go/source/detail?r=a0de9da0017e&repo=image ***

tiff: support writing files with differencing predictor.

This will make more sense after implementing compression.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6567077

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b