Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(429)

Issue 6566054: code review 6566054: reflect.DeepEqual: rewrite clarification about nil and ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by r
Modified:
12 years, 6 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

reflect.DeepEqual: rewrite clarification about nil and empty slice. The previous version was created by an idiot. This time, Rog Peppe wrote the text. Thanks, Rog. (== doesn't work on slices in general, so it makes no sense to talk about in the context of DeepEqual.)

Patch Set 1 #

Patch Set 2 : diff -r 21d7e670084d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/reflect/deepequal.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 6 months ago (2012-09-26 09:48:52 UTC) #1
dsymonds
LGTM but I would have used a more straightforward "An empty slice is not equal ...
12 years, 6 months ago (2012-09-26 10:05:01 UTC) #2
r
12 years, 6 months ago (2012-09-26 10:47:14 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=99bb8c9e067d ***

reflect.DeepEqual: rewrite clarification about nil and empty slice.
The previous version was created by an idiot. This time, Rog Peppe
wrote the text. Thanks, Rog.
(== doesn't work on slices in general, so it makes no sense to
talk about in the context of DeepEqual.)

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6566054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b