Issue 6566051: samplecode: Remove duplicated include of SkWindow.h from SampleApp.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6566051: samplecode: Remove duplicated include of SkWindow.h from SampleApp.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by tfarina1

Modified:
12 years, 2 months ago

Reviewers:
epoger, TomH

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

samplecode: Remove duplicated include of SkWindow.h from SampleApp.h R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=5737

Patch Set 4 : fix nit #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	samplecode/SampleApp.h	View	1 2 3	2 chunks	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

tfarina1

On 2012/09/29 12:15:34, TomH wrote: > LGTM modulo nit. Forgot to send the nit? ;)

12 years, 2 months ago (2012-09-29 12:33:26 UTC) #3

TomH

Yep. https://codereview.appspot.com/6566051/diff/3001/samplecode/SampleApp.h File samplecode/SampleApp.h (right): https://codereview.appspot.com/6566051/diff/3001/samplecode/SampleApp.h#newcode9 samplecode/SampleApp.h:9: Good catch on the #define name. Nit: please ...

12 years, 2 months ago (2012-09-29 12:33:39 UTC) #4

tfarina1

12 years, 2 months ago (2012-09-29 12:38:31 UTC) #5

Thanks, submitting.

https://codereview.appspot.com/6566051/diff/3001/samplecode/SampleApp.h
File samplecode/SampleApp.h (right):

https://codereview.appspot.com/6566051/diff/3001/samplecode/SampleApp.h#newcode9
samplecode/SampleApp.h:9: 
On 2012/09/29 12:33:39, TomH wrote:
> Good catch on the #define name.
> Nit: please remove extra space.
Ops, fixed.

Expand All Messages | Collapse All Messages