Issue 6566049: Remove SkListWidget.cpp, which has not been compiled for 18 months

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6566049: Remove SkListWidget.cpp, which has not been compiled for 18 months (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by epoger

Modified:
12 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, tfarina1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove SkListWidget.cpp, which has not been compiled for 18 months (Our very first gyp file from https://code.google.com/p/skia/source/detail?spec=svn955&r=955 already had it turned off) Committed: https://code.google.com/p/skia/source/detail?r=5668

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -635 lines)			Patch
	M	gyp/views_animated.gyp	View		2 chunks	+0 lines, -5 lines	0 comments	Download
	D	src/views/animated/SkListWidget.cpp	View		1 chunk	+0 lines, -630 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

This came up while reviewing https://codereview.appspot.com/6550046/ ('views: Delete arrays throughout using SkDELETE_ARRAY macro.')

12 years, 2 months ago (2012-09-25 18:21:56 UTC) #1

bsalomon

12 years, 2 months ago (2012-09-25 18:23:59 UTC) #2

On 2012/09/25 18:21:56, epoger wrote:
> This came up while reviewing https://codereview.appspot.com/6550046/ ('views:
> Delete arrays throughout using SkDELETE_ARRAY macro.')

LGTM.

Expand All Messages | Collapse All Messages