Issue 6564052: code review 6564052: cmd/gc: Don't calculate second value in range if it is ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6564052: code review 6564052: cmd/gc: Don't calculate second value in range if it is ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by DMorsing

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: Don't calculate second value in range if it is blank. Low hanging fruit optimization. Will remove an expensive copy if the range variable is an array.

Patch Set 1 #

Patch Set 2 : diff -r 99bb8c9e067d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 99bb8c9e067d https://code.google.com/p/go/ #

Patch Set 4 : diff -r aa52f2efc386 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/cmd/gc/range.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DMorsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-09-26 11:53:07 UTC) #1

DMorsing

13 years, 2 months ago (2012-09-26 19:10:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=599552ae08cd ***

cmd/gc: Don't calculate second value in range if it is blank.

Low hanging fruit optimization. Will remove an expensive copy if the range
variable is an array.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6564052

Expand All Messages | Collapse All Messages