Issue 6562045: worker/uniter: fix things after new state

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6562045: worker/uniter: fix things after new state

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by niemeyer

Modified:
11 years, 7 months ago

Reviewers:
mp+126120, fwereade

Visibility:
Public.

Description

worker/uniter: fix things after new state THIS IS WORK IN PROGRESS. https://code.launchpad.net/~niemeyer/juju-core/new-state-uniter/+merge/126120 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -59 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/unit_test.go	View	1 chunk	+14 lines, -8 lines	0 comments	Download
M	worker/uniter/modes.go	View	5 chunks	+31 lines, -23 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	3 chunks	+22 lines, -26 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

This is more-or-less *precisely* what I had, but your test changes are cleaner. LGTM :).

11 years, 7 months ago (2012-09-24 22:55:35 UTC) #1

fwereade

11 years, 7 months ago (2012-09-24 23:13:35 UTC) #2

On 2012/09/24 22:55:35, fwereade wrote:
> This is more-or-less *precisely* what I had, but your test changes are
cleaner.
> LGTM :).

(Oh, except, they aren't actually passing yet. I'll pull from here and continue)

Expand All Messages | Collapse All Messages