Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6560063: code review 6560063: test: match gccgo error messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by iant
Modified:
12 years, 6 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

test: match gccgo error messages const1.go:31:12: error: integer constant overflow const1.go:31:12: error: integer constant overflow const1.go:33:12: error: integer constant overflow const1.go:33:12: error: integer constant overflow const1.go:34:14: error: integer constant overflow const1.go:35:17: error: integer constant overflow const1.go:35:17: error: integer constant overflow const1.go:35:17: error: integer constant overflow const1.go:35:17: error: integer constant overflow const1.go:35:17: error: integer constant overflow const1.go:36:19: error: integer constant overflow const1.go:37:15: error: integer constant overflow const1.go:37:15: error: integer constant overflow const1.go:37:24: error: integer constant overflow const1.go:37:15: error: integer constant overflow const1.go:37:15: error: integer constant overflow const1.go:37:15: error: integer constant overflow const1.go:37:24: error: integer constant overflow const1.go:37:15: error: integer constant overflow const1.go:38:12: error: integer constant overflow const1.go:38:12: error: integer constant overflow const1.go:38:12: error: integer constant overflow const1.go:38:12: error: integer constant overflow const1.go:41:20: error: integer constant overflow const1.go:41:20: error: integer constant overflow const1.go:42:20: error: integer constant overflow const1.go:42:20: error: integer constant overflow const1.go:44:28: error: integer constant overflow const1.go:44:28: error: integer constant overflow const1.go:45:14: error: integer constant overflow const1.go:49:14: error: integer constant overflow const1.go:50:14: error: integer constant overflow const1.go:51:14: error: integer constant overflow const1.go:54:23: error: integer constant overflow const1.go:54:23: error: integer constant overflow const1.go:54:23: error: integer constant overflow const1.go:54:23: error: integer constant overflow const1.go:56:14: error: integer constant overflow const1.go:57:24: error: integer constant overflow const1.go:57:24: error: integer constant overflow const1.go:58:24: error: integer constant overflow const1.go:58:24: error: integer constant overflow const1.go:59:22: error: integer constant overflow const1.go:59:22: error: integer constant overflow const1.go:61:24: error: integer constant overflow const1.go:62:20: error: division by zero const1.go:65:19: error: floating point constant overflow const1.go:65:19: error: floating point constant overflow const1.go:66:28: error: floating point constant overflow const1.go:66:28: error: floating point constant overflow const1.go:67:19: error: floating point constant overflow const1.go:67:19: error: floating point constant overflow const1.go:68:19: error: division by zero const1.go:33:14: error: integer constant overflow const1.go:35:19: error: integer constant overflow const1.go:42:22: error: integer constant overflow const1.go:53:17: error: integer constant overflow const1.go:55:14: error: integer constant overflow const1.go:59:24: error: integer constant overflow const1.go:69:20: error: expected integer type const1.go:75:4: error: argument 1 has incompatible type (cannot use type int8 as type int) const1.go:76:4: error: argument 1 has incompatible type (cannot use type int8 as type int) const1.go:77:4: error: argument 1 has incompatible type (cannot use type uint8 as type int) const1.go:79:4: error: argument 1 has incompatible type (cannot use type float32 as type int) const1.go:80:4: error: argument 1 has incompatible type (cannot use type float64 as type int) const1.go:81:4: error: floating point constant truncated to integer const1.go:83:4: error: argument 1 has incompatible type (cannot use type float64 as type int) const1.go:84:4: error: argument 1 has incompatible type (cannot use type string as type int) const1.go:85:4: error: argument 1 has incompatible type (cannot use type bool as type int) const1.go:88:7: error: const initializer cannot be nil const2.go:14:8: error: expected ‘=’ const5.go:27:7: error: expression is not constant const5.go:28:7: error: expression is not constant const5.go:30:7: error: expression is not constant const5.go:31:7: error: expression is not constant ddd1.go:57:23: error: invalid use of ‘...’ in type conversion ddd1.go:59:6: error: invalid use of ‘...’ in type conversion ddd1.go:60:12: error: use of ‘[...]’ outside of array literal ddd1.go:21:15: error: argument 1 has incompatible type ddd1.go:22:10: error: argument 1 has incompatible type ddd1.go:30:6: error: invalid use of ‘...’ with non-slice ddd1.go:30:6: error: invalid use of ‘...’ with non-slice ddd1.go:46:2: error: invalid use of %<...%> with builtin function ddd1.go:47:2: error: invalid use of %<...%> with builtin function ddd1.go:49:2: error: invalid use of %<...%> with builtin function ddd1.go:50:6: error: invalid use of %<...%> with builtin function ddd1.go:51:6: error: invalid use of %<...%> with builtin function ddd1.go:53:6: error: invalid use of %<...%> with builtin function ddd1.go:58:13: error: invalid use of %<...%> with builtin function ddd1.go:20:10: error: floating point constant truncated to integer ddd1.go:32:6: error: invalid use of ‘...’ calling non-variadic function declbad.go:20:3: error: variables redeclared but no variable is new declbad.go:38:3: error: variables redeclared but no variable is new declbad.go:44:3: error: variables redeclared but no variable is new declbad.go:51:3: error: variables redeclared but no variable is new declbad.go:57:3: error: variables redeclared but no variable is new declbad.go:63:3: error: variables redeclared but no variable is new declbad.go:26:3: error: incompatible types in assignment (cannot use type float32 as type int) declbad.go:32:3: error: incompatible types in assignment (cannot use type int as type float32) declbad.go:44:3: error: incompatible types in assignment (different number of results) fixedbugs/bug223.go:21:5: error: initialization expression for ‘m’ depends upon itself fixedbugs/bug412.go:10:2: error: duplicate field name ‘x’ fixedbugs/bug413.go:11:5: error: initialization expression for ‘i’ depends upon itself fixedbugs/bug416.go:13:1: error: method ‘X’ redeclares struct field name fixedbugs/bug435.go:15:49: error: missing ‘)’ fixedbugs/bug435.go:15:2: error: reference to undefined name ‘bar’ fixedbugs/bug451.go:9:9: error: expected package typeswitch3.go:39:9: error: no new variables on left side of ‘:=’ typeswitch3.go:24:2: error: impossible type switch case (type has no methods)

Patch Set 1 #

Patch Set 2 : diff -r 0a0a751f0b74 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M test/const1.go View 1 chunk +1 line, -1 line 0 comments Download
M test/const2.go View 1 chunk +2 lines, -2 lines 0 comments Download
M test/const5.go View 1 chunk +4 lines, -4 lines 0 comments Download
M test/ddd1.go View 1 chunk +2 lines, -2 lines 0 comments Download
M test/declbad.go View 1 chunk +2 lines, -1 line 0 comments Download
M test/fixedbugs/bug223.go View 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug412.go View 1 chunk +2 lines, -2 lines 0 comments Download
M test/fixedbugs/bug413.go View 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug416.go View 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug435.go View 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug451.go View 1 chunk +1 line, -1 line 0 comments Download
M test/typeswitch3.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 6 months ago (2012-09-28 14:22:10 UTC) #1
rsc
LGTM
12 years, 6 months ago (2012-09-28 15:20:29 UTC) #2
iant
12 years, 6 months ago (2012-09-28 15:30:36 UTC) #3 
*** Submitted as http://code.google.com/p/go/source/detail?r=59ff5c940b89 ***

test: match gccgo error messages

const1.go:31:12: error: integer constant overflow
const1.go:31:12: error: integer constant overflow
const1.go:33:12: error: integer constant overflow
const1.go:33:12: error: integer constant overflow
const1.go:34:14: error: integer constant overflow
const1.go:35:17: error: integer constant overflow
const1.go:35:17: error: integer constant overflow
const1.go:35:17: error: integer constant overflow
const1.go:35:17: error: integer constant overflow
const1.go:35:17: error: integer constant overflow
const1.go:36:19: error: integer constant overflow
const1.go:37:15: error: integer constant overflow
const1.go:37:15: error: integer constant overflow
const1.go:37:24: error: integer constant overflow
const1.go:37:15: error: integer constant overflow
const1.go:37:15: error: integer constant overflow
const1.go:37:15: error: integer constant overflow
const1.go:37:24: error: integer constant overflow
const1.go:37:15: error: integer constant overflow
const1.go:38:12: error: integer constant overflow
const1.go:38:12: error: integer constant overflow
const1.go:38:12: error: integer constant overflow
const1.go:38:12: error: integer constant overflow
const1.go:41:20: error: integer constant overflow
const1.go:41:20: error: integer constant overflow
const1.go:42:20: error: integer constant overflow
const1.go:42:20: error: integer constant overflow
const1.go:44:28: error: integer constant overflow
const1.go:44:28: error: integer constant overflow
const1.go:45:14: error: integer constant overflow
const1.go:49:14: error: integer constant overflow
const1.go:50:14: error: integer constant overflow
const1.go:51:14: error: integer constant overflow
const1.go:54:23: error: integer constant overflow
const1.go:54:23: error: integer constant overflow
const1.go:54:23: error: integer constant overflow
const1.go:54:23: error: integer constant overflow
const1.go:56:14: error: integer constant overflow
const1.go:57:24: error: integer constant overflow
const1.go:57:24: error: integer constant overflow
const1.go:58:24: error: integer constant overflow
const1.go:58:24: error: integer constant overflow
const1.go:59:22: error: integer constant overflow
const1.go:59:22: error: integer constant overflow
const1.go:61:24: error: integer constant overflow
const1.go:62:20: error: division by zero
const1.go:65:19: error: floating point constant overflow
const1.go:65:19: error: floating point constant overflow
const1.go:66:28: error: floating point constant overflow
const1.go:66:28: error: floating point constant overflow
const1.go:67:19: error: floating point constant overflow
const1.go:67:19: error: floating point constant overflow
const1.go:68:19: error: division by zero
const1.go:33:14: error: integer constant overflow
const1.go:35:19: error: integer constant overflow
const1.go:42:22: error: integer constant overflow
const1.go:53:17: error: integer constant overflow
const1.go:55:14: error: integer constant overflow
const1.go:59:24: error: integer constant overflow
const1.go:69:20: error: expected integer type
const1.go:75:4: error: argument 1 has incompatible type (cannot use type int8 as
type int)
const1.go:76:4: error: argument 1 has incompatible type (cannot use type int8 as
type int)
const1.go:77:4: error: argument 1 has incompatible type (cannot use type uint8
as type int)
const1.go:79:4: error: argument 1 has incompatible type (cannot use type float32
as type int)
const1.go:80:4: error: argument 1 has incompatible type (cannot use type float64
as type int)
const1.go:81:4: error: floating point constant truncated to integer
const1.go:83:4: error: argument 1 has incompatible type (cannot use type float64
as type int)
const1.go:84:4: error: argument 1 has incompatible type (cannot use type string
as type int)
const1.go:85:4: error: argument 1 has incompatible type (cannot use type bool as
type int)
const1.go:88:7: error: const initializer cannot be nil

const2.go:14:8: error: expected ‘=’

const5.go:27:7: error: expression is not constant
const5.go:28:7: error: expression is not constant
const5.go:30:7: error: expression is not constant
const5.go:31:7: error: expression is not constant

ddd1.go:57:23: error: invalid use of ‘...’ in type conversion
ddd1.go:59:6: error: invalid use of ‘...’ in type conversion
ddd1.go:60:12: error: use of ‘[...]’ outside of array literal
ddd1.go:21:15: error: argument 1 has incompatible type
ddd1.go:22:10: error: argument 1 has incompatible type
ddd1.go:30:6: error: invalid use of ‘...’ with non-slice
ddd1.go:30:6: error: invalid use of ‘...’ with non-slice
ddd1.go:46:2: error: invalid use of %<...%> with builtin function
ddd1.go:47:2: error: invalid use of %<...%> with builtin function
ddd1.go:49:2: error: invalid use of %<...%> with builtin function
ddd1.go:50:6: error: invalid use of %<...%> with builtin function
ddd1.go:51:6: error: invalid use of %<...%> with builtin function
ddd1.go:53:6: error: invalid use of %<...%> with builtin function
ddd1.go:58:13: error: invalid use of %<...%> with builtin function
ddd1.go:20:10: error: floating point constant truncated to integer
ddd1.go:32:6: error: invalid use of ‘...’ calling non-variadic function

declbad.go:20:3: error: variables redeclared but no variable is new
declbad.go:38:3: error: variables redeclared but no variable is new
declbad.go:44:3: error: variables redeclared but no variable is new
declbad.go:51:3: error: variables redeclared but no variable is new
declbad.go:57:3: error: variables redeclared but no variable is new
declbad.go:63:3: error: variables redeclared but no variable is new
declbad.go:26:3: error: incompatible types in assignment (cannot use type
float32 as type int)
declbad.go:32:3: error: incompatible types in assignment (cannot use type int as
type float32)
declbad.go:44:3: error: incompatible types in assignment (different number of
results)

fixedbugs/bug223.go:21:5: error: initialization expression for ‘m’ depends upon
itself

fixedbugs/bug412.go:10:2: error: duplicate field name ‘x’

fixedbugs/bug413.go:11:5: error: initialization expression for ‘i’ depends upon
itself

fixedbugs/bug416.go:13:1: error: method ‘X’ redeclares struct field name

fixedbugs/bug435.go:15:49: error: missing ‘)’
fixedbugs/bug435.go:15:2: error: reference to undefined name ‘bar’

fixedbugs/bug451.go:9:9: error: expected package

typeswitch3.go:39:9: error: no new variables on left side of ‘:=’
typeswitch3.go:24:2: error: impossible type switch case (type has no methods)

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6560063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b