Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 6555049: code review 6555049: codereview: use subprocess.call() instead of os.spawnvp...

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by shiv
Modified:
2 years, 11 months ago
Reviewers:
r, minux1
CC:
golang-dev, minux1, dfc, r
Visibility:
Public.

Description

codereview: use subprocess.call() instead of os.spawnvp() for portability Fixes issue 4121.

Patch Set 1 : diff -r 90c9121e26c3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/codereview/codereview.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12
shiv
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
2 years, 11 months ago (2012-09-21 16:32:19 UTC) #1
minux1
the change LGTM. On Saturday, September 22, 2012, wrote: > > Description: > codereview.py : ...
2 years, 11 months ago (2012-09-22 04:44:08 UTC) #2
shiv
What is the procedure to change the description text that is already submitted to codereview? ...
2 years, 11 months ago (2012-09-22 11:43:30 UTC) #3
dfc
hg change 6555049 will let you edit the CL description then hg mail 6555049 http://golang.org/doc/contribute.html#tmp_65 ...
2 years, 11 months ago (2012-09-22 11:59:08 UTC) #4
shiv
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
2 years, 11 months ago (2012-09-22 13:42:32 UTC) #5
shiv
On 2012/09/22 11:59:08, dfc wrote: > hg change 6555049 > > will let you edit ...
2 years, 11 months ago (2012-09-22 13:49:14 UTC) #6
dfc
> Unfortunately this hint does not work if the change is *only* for commit > ...
2 years, 11 months ago (2012-09-22 13:51:28 UTC) #7
shiv
On 2012/09/22 13:51:28, dfc wrote: > > Please raise a bug for this, hg change ...
2 years, 11 months ago (2012-09-22 14:15:40 UTC) #8
minux1
Any more comments about this CL? I will wait for 1 day before submitting.
2 years, 11 months ago (2012-09-24 08:47:05 UTC) #9
r
LGTM make sure he's in the CLA
2 years, 11 months ago (2012-09-24 09:40:21 UTC) #10
shiv
On 2012/09/24 09:40:21, r wrote: > LGTM > make sure he's in the CLA I ...
2 years, 11 months ago (2012-09-24 12:50:38 UTC) #11
minux1
2 years, 11 months ago (2012-09-26 17:51:16 UTC) #12
*** Submitted as http://code.google.com/p/go/source/detail?r=b6d8227d99ae ***

codereview: use subprocess.call() instead of os.spawnvp() for portability

Fixes issue 4121.

R=golang-dev, minux.ma, dave, r
CC=golang-dev
http://codereview.appspot.com/6555049

Committer: Shenghou Ma <minux.ma@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld fd993c8