Issue 6554045: Remove automatic resizing in *_pictures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6554045: Remove automatic resizing in *_pictures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by EricB

Modified:
12 years, 3 months ago

Reviewers:
Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Remove automatic resizing in *_pictures Committed: https://code.google.com/p/skia/source/detail?r=5614

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -70 lines)			Patch
M	tools/bench_pictures_main.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	tools/picture_utils.h	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	tools/picture_utils.cpp	View	1	2 chunks	+0 lines, -45 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download

Total messages: 6

EricB

Note that I didn't remove the resizing functions from picture_utils.

12 years, 3 months ago (2012-09-20 15:39:46 UTC) #1

Leon

On 2012/09/20 15:39:46, EricB wrote: > Note that I didn't remove the resizing functions from ...

12 years, 3 months ago (2012-09-20 15:40:58 UTC) #2

EricB

On 2012/09/20 15:40:58, scroggo-work wrote: > On 2012/09/20 15:39:46, EricB wrote: > > Note that ...

12 years, 3 months ago (2012-09-20 15:44:18 UTC) #3

EricB

On 2012/09/20 15:44:18, EricB wrote: > On 2012/09/20 15:40:58, scroggo-work wrote: > > On 2012/09/20 ...

12 years, 3 months ago (2012-09-20 15:51:53 UTC) #4

Leon

On 2012/09/20 15:44:18, EricB wrote: > On 2012/09/20 15:40:58, scroggo-work wrote: > > On 2012/09/20 ...

12 years, 3 months ago (2012-09-20 15:52:43 UTC) #5

lgtm